-
Notifications
You must be signed in to change notification settings - Fork 104
feat(eap): Produce spans to the items topic #4735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This will be done in the buffer instead: Differences from this implementation:
|
|
This will not move forward, we'll stick with the buffer producing to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed, to make the transition possible from one topic to the other (with a different item format), we implement a double write, with an optional config flag to disable/enable the snuba-spans and snuba-items topics.
We cannot always double write, because that means we will double produce to clickhouse (as the buffer writes to snuba-items) as well.
Co-authored-by: David Herberth <[email protected]>
Co-authored-by: David Herberth <[email protected]>
Co-authored-by: David Herberth <[email protected]>
To do:
span.datato the attributesingest-spans