Skip to content

Conversation

@phacops
Copy link
Contributor

@phacops phacops commented May 13, 2025

To do:

  • Add span.data to the attributes
  • Add missing root fields to attributes
  • Add missing attributes added in the current Snuba consumer
  • Fix integration tests
  • Produce the JSON-encoded span to ingest-spans

@phacops phacops marked this pull request as ready for review May 14, 2025 21:13
@phacops phacops requested a review from a team as a code owner May 14, 2025 21:13
@phacops phacops requested a review from Dav1dde May 14, 2025 22:00
@jan-auer
Copy link
Member

This will be done in the buffer instead:
getsentry/sentry#91714

Differences from this implementation:

  • Maps hash to sentry.hash
  • Includes sub-second parts in timestamps

@phacops
Copy link
Contributor Author

phacops commented May 21, 2025

This will not move forward, we'll stick with the buffer producing to snuba-items directly.

@phacops phacops closed this May 21, 2025
@phacops phacops reopened this Jun 9, 2025
Copy link
Member

@Dav1dde Dav1dde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, to make the transition possible from one topic to the other (with a different item format), we implement a double write, with an optional config flag to disable/enable the snuba-spans and snuba-items topics.

We cannot always double write, because that means we will double produce to clickhouse (as the buffer writes to snuba-items) as well.

phacops and others added 3 commits June 13, 2025 12:00
Co-authored-by: David Herberth <[email protected]>
@phacops phacops enabled auto-merge (squash) June 23, 2025 19:55
@phacops phacops merged commit 8601508 into master Jun 23, 2025
44 of 47 checks passed
@phacops phacops deleted the pierre/eap-spans-to-items-topic branch June 23, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants