- 
          
- 
                Notifications
    You must be signed in to change notification settings 
- Fork 372
ref: Envelope deserialization to Swift #6186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| Codecov Report❌ Patch coverage is  
 Additional details and impacted files@@              Coverage Diff              @@
##              main     #6186       +/-   ##
=============================================
+ Coverage   86.699%   86.718%   +0.019%     
=============================================
  Files          436       436               
  Lines        37089     37090        +1     
  Branches     17399     17363       -36     
=============================================
+ Hits         32156     32164        +8     
+ Misses        4889      4653      -236     
- Partials        44       273      +229     
 ... and 41 files with indirect coverage changes Continue to review full report in Codecov by Sentry. 
 | 
| Performance metrics 🚀
 
 | 
| Revision | Plain | With Sentry | Diff | 
|---|---|---|---|
| 7c7ac56 | 1225.90 ms | 1250.22 ms | 24.33 ms | 
| 8ea5293 | 1242.70 ms | 1262.25 ms | 19.55 ms | 
| 35c962f | 1207.61 ms | 1235.90 ms | 28.29 ms | 
| aa98fe8 | 1227.69 ms | 1253.18 ms | 25.50 ms | 
| 339539a | 1219.58 ms | 1254.63 ms | 35.05 ms | 
| 0ac4c65 | 1236.85 ms | 1267.84 ms | 30.98 ms | 
| 6ee4973 | 1228.42 ms | 1252.26 ms | 23.84 ms | 
| b13e93a | 1236.24 ms | 1247.33 ms | 11.08 ms | 
| 2e79f5f | 1220.53 ms | 1249.35 ms | 28.82 ms | 
| 5ae9ff1 | 1222.31 ms | 1250.96 ms | 28.65 ms | 
App size
| Revision | Plain | With Sentry | Diff | 
|---|---|---|---|
| 7c7ac56 | 23.75 KiB | 902.49 KiB | 878.74 KiB | 
| 8ea5293 | 23.75 KiB | 852.24 KiB | 828.49 KiB | 
| 35c962f | 23.75 KiB | 854.77 KiB | 831.02 KiB | 
| aa98fe8 | 23.75 KiB | 891.01 KiB | 867.26 KiB | 
| 339539a | 23.75 KiB | 968.24 KiB | 944.50 KiB | 
| 0ac4c65 | 23.75 KiB | 968.24 KiB | 944.50 KiB | 
| 6ee4973 | 23.75 KiB | 896.53 KiB | 872.79 KiB | 
| b13e93a | 23.75 KiB | 855.37 KiB | 831.62 KiB | 
| 2e79f5f | 23.75 KiB | 928.87 KiB | 905.12 KiB | 
| 5ae9ff1 | 23.74 KiB | 971.82 KiB | 948.08 KiB | 
Previous results on branch: envelopeDeserializeSwift
Startup times
| Revision | Plain | With Sentry | Diff | 
|---|---|---|---|
| 7710a76 | 1228.43 ms | 1244.53 ms | 16.10 ms | 
| 4f59363 | 1222.23 ms | 1250.30 ms | 28.07 ms | 
| b27584f | 1213.15 ms | 1225.34 ms | 12.19 ms | 
| dd0291a | 1200.69 ms | 1235.64 ms | 34.94 ms | 
App size
| Revision | Plain | With Sentry | Diff | 
|---|---|---|---|
| 7710a76 | 23.75 KiB | 976.94 KiB | 953.19 KiB | 
| 4f59363 | 23.75 KiB | 977.33 KiB | 953.58 KiB | 
| b27584f | 23.75 KiB | 977.31 KiB | 953.57 KiB | 
| dd0291a | 23.75 KiB | 977.30 KiB | 953.56 KiB | 
956cca3    to
    62e2308      
    Compare
  
    62e2308    to
    dce6537      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woah, this code is complex 🤯 . Thanks for converting it to Swift. It looks way better now.
| 🚨 Detected changes in high risk code 🚨High-risk code can easily blow up and is hard to test. We had severe bugs in the past. Be extra careful when changing these files, and have an extra careful look at these: 
 | 
* ref: Envelope deserialization to Swift * PR feedback
Converts one more deserialization function to Swift, this one was a bit long but pretty straightforward and very thoroughly unit tested
#skip-changelog
Closes #6190