Skip to content

Conversation

@marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Nov 18, 2022

📜 Description

Add missing SDK integrations
#skip-changelog

💡 Motivation and Context

So we can track the adoption and prioritization of each feature.

💚 How did you test it?

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2022

Codecov Report

Base: 90.09% // Head: 91.00% // Increases project coverage by +0.91% 🎉

Coverage data is based on head (6748c80) compared to base (6d7a391).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1145      +/-   ##
==========================================
+ Coverage   90.09%   91.00%   +0.91%     
==========================================
  Files         119        9     -110     
  Lines        3644      189    -3455     
==========================================
- Hits         3283      172    -3111     
+ Misses        361       17     -344     
Impacted Files Coverage Δ
dio/lib/src/sentry_dio_extension.dart 76.92% <0.00%> (-6.42%) ⬇️
dio/lib/src/sentry_dio_client_adapter.dart 80.00% <100.00%> (+2.22%) ⬆️
...art/lib/src/http_client/failed_request_client.dart
dart/lib/src/http_client/sentry_http_client.dart
dart/lib/src/protocol/sdk_version.dart
dart/lib/src/client_reports/client_report.dart
...rt/lib/src/sentry_client_attachment_processor.dart
dart/lib/src/sentry_traces_sampling_decision.dart
...lib/src/invalid_sentry_trace_header_exception.dart
dart/lib/src/protocol/sentry_geo.dart
... and 102 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 327.00 ms 383.64 ms 56.64 ms
Size 5.94 MiB 6.95 MiB 1.01 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
633cf2e 289.36 ms 340.38 ms 51.02 ms
d7758e8 300.12 ms 349.88 ms 49.76 ms
08a7b4f 346.47 ms 403.29 ms 56.82 ms
b728df4 390.98 ms 445.81 ms 54.83 ms
870f5eb 329.45 ms 369.29 ms 39.84 ms
eb1a7c1 332.98 ms 381.55 ms 48.57 ms
ccc09e4 308.21 ms 357.74 ms 49.54 ms
abcdba3 354.68 ms 399.04 ms 44.36 ms
a609134 350.12 ms 404.12 ms 54.00 ms
a49594a 282.27 ms 344.84 ms 62.57 ms

App size

Revision Plain With Sentry Diff
633cf2e 5.94 MiB 6.92 MiB 1001.53 KiB
d7758e8 5.94 MiB 6.95 MiB 1.01 MiB
08a7b4f 5.94 MiB 6.95 MiB 1.01 MiB
b728df4 5.94 MiB 6.95 MiB 1.01 MiB
870f5eb 5.94 MiB 6.92 MiB 1005.77 KiB
eb1a7c1 5.94 MiB 6.92 MiB 1005.76 KiB
ccc09e4 5.94 MiB 6.95 MiB 1.01 MiB
abcdba3 5.94 MiB 6.95 MiB 1.01 MiB
a609134 5.94 MiB 6.95 MiB 1.01 MiB
a49594a 5.94 MiB 6.95 MiB 1.01 MiB

@github-actions
Copy link
Contributor

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1257.06 ms 1270.04 ms 12.98 ms
Size 8.16 MiB 9.16 MiB 1.01 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
633cf2e 1257.96 ms 1275.73 ms 17.77 ms
3e9fb0e 1262.49 ms 1280.65 ms 18.16 ms
eb1a7c1 1281.25 ms 1295.40 ms 14.15 ms
25e9b59 1289.76 ms 1295.27 ms 5.51 ms
6d317ea 1277.27 ms 1287.47 ms 10.20 ms
559d28f 1265.04 ms 1288.96 ms 23.92 ms
3e5ee37 1248.25 ms 1265.38 ms 17.13 ms
48e79fd 1282.96 ms 1296.12 ms 13.17 ms
f922f8f 1249.53 ms 1266.51 ms 16.98 ms
a49594a 1284.83 ms 1313.29 ms 28.45 ms

App size

Revision Plain With Sentry Diff
633cf2e 8.15 MiB 9.12 MiB 986.26 KiB
3e9fb0e 8.15 MiB 9.12 MiB 989.77 KiB
eb1a7c1 8.15 MiB 9.13 MiB 1000.10 KiB
25e9b59 8.16 MiB 9.15 MiB 1021.15 KiB
6d317ea 8.15 MiB 9.12 MiB 986.26 KiB
559d28f 8.15 MiB 9.12 MiB 987.32 KiB
3e5ee37 8.15 MiB 9.12 MiB 986.23 KiB
48e79fd 8.16 MiB 9.15 MiB 1021.87 KiB
f922f8f 8.15 MiB 9.13 MiB 1003.20 KiB
a49594a 8.16 MiB 9.16 MiB 1.00 MiB

Copy link
Contributor

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good.
Maybe we should have some tests to avoid regression.

@marandaneto marandaneto merged commit 134c9f8 into main Nov 18, 2022
@marandaneto marandaneto deleted the chore/add-sdk-integrations branch November 18, 2022 14:52
@marandaneto
Copy link
Contributor Author

Implementation looks good. Maybe we should have some tests to avoid regression.

Will add in another PR to unblock this release, since this has no risk.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants