Skip to content

Conversation

buenaflor
Copy link
Contributor

@buenaflor buenaflor commented Oct 8, 2025

📜 Description

Part of moving away from method channels

💡 Motivation and Context

Closes #3206

💚 How did you test it?

  • Unit test checking method channels are not invoked anymore
  • Integration test checking it loads the correct data

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

@buenaflor buenaflor marked this pull request as ready for review October 9, 2025 11:14
cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

Base automatically changed from enh/long-lived-envelope-worker to main October 13, 2025 11:07
Copy link
Contributor

github-actions bot commented Oct 14, 2025

Android Performance metrics 🚀

  Plain With Sentry Diff
Startup time 506.06 ms 516.57 ms 10.51 ms
Size 13.93 MiB 15.06 MiB 1.13 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
3615e19 468.38 ms 504.71 ms 36.33 ms
8541716 437.14 ms 443.65 ms 6.51 ms
de377fd 572.35 ms 589.21 ms 16.87 ms
6ba4675 499.80 ms 632.43 ms 132.63 ms
4298701 524.40 ms 633.30 ms 108.90 ms
8825ed8 447.65 ms 456.90 ms 9.25 ms
c8596a6 474.00 ms 492.96 ms 18.96 ms
eca355d 485.50 ms 569.85 ms 84.35 ms
b6c8720 457.41 ms 519.04 ms 61.63 ms
944b773 470.54 ms 480.18 ms 9.64 ms

App size

Revision Plain With Sentry Diff
3615e19 6.54 MiB 7.70 MiB 1.16 MiB
8541716 13.93 MiB 15.00 MiB 1.06 MiB
de377fd 6.54 MiB 7.71 MiB 1.17 MiB
6ba4675 6.54 MiB 7.53 MiB 1015.26 KiB
4298701 6.54 MiB 7.71 MiB 1.17 MiB
8825ed8 13.93 MiB 14.93 MiB 1.00 MiB
c8596a6 6.54 MiB 7.53 MiB 1015.27 KiB
eca355d 6.54 MiB 7.70 MiB 1.16 MiB
b6c8720 6.54 MiB 7.69 MiB 1.15 MiB
944b773 13.93 MiB 15.00 MiB 1.06 MiB

Previous results on branch: enh/app-start-refresh-rate-jni-ffi

Startup times

Revision Plain With Sentry Diff
9733bc8 418.61 ms 457.02 ms 38.41 ms
7750213 442.50 ms 439.90 ms -2.60 ms
2f1840d 436.18 ms 422.55 ms -13.63 ms
60f9674 487.92 ms 490.90 ms 2.98 ms
3eeda60 483.35 ms 483.61 ms 0.27 ms
e744a5e 487.30 ms 481.92 ms -5.38 ms
1ffba6f 424.28 ms 420.04 ms -4.24 ms
dee9256 416.28 ms 469.06 ms 52.78 ms
2cd6dd8 503.51 ms 519.92 ms 16.41 ms
91b0298 423.63 ms 423.14 ms -0.49 ms

App size

Revision Plain With Sentry Diff
9733bc8 13.93 MiB 15.06 MiB 1.13 MiB
7750213 13.93 MiB 15.06 MiB 1.13 MiB
2f1840d 13.93 MiB 15.06 MiB 1.13 MiB
60f9674 13.93 MiB 15.06 MiB 1.13 MiB
3eeda60 13.93 MiB 15.06 MiB 1.13 MiB
e744a5e 13.93 MiB 15.06 MiB 1.13 MiB
1ffba6f 13.93 MiB 15.06 MiB 1.13 MiB
dee9256 13.93 MiB 15.06 MiB 1.13 MiB
2cd6dd8 13.93 MiB 15.06 MiB 1.13 MiB
91b0298 13.93 MiB 15.06 MiB 1.13 MiB

Copy link
Contributor

github-actions bot commented Oct 14, 2025

iOS Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1251.98 ms 1255.91 ms 3.94 ms
Size 5.53 MiB 6.00 MiB 487.15 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
827bf09 1261.86 ms 1276.41 ms 14.55 ms
6bcdc99 1257.16 ms 1264.96 ms 7.79 ms
0fb3800 1256.60 ms 1266.28 ms 9.68 ms
cf443d2 1255.79 ms 1248.38 ms -7.40 ms
81f83eb 1259.53 ms 1273.39 ms 13.86 ms
73a3c38 1263.37 ms 1277.90 ms 14.53 ms
54acf91 1257.65 ms 1277.96 ms 20.31 ms
a10aff4 1241.67 ms 1255.02 ms 13.35 ms
32914d8 1275.47 ms 1285.20 ms 9.73 ms
7b21e8b 1256.79 ms 1267.12 ms 10.33 ms

App size

Revision Plain With Sentry Diff
827bf09 7.86 MiB 9.44 MiB 1.58 MiB
6bcdc99 5.53 MiB 6.00 MiB 479.95 KiB
0fb3800 7.86 MiB 9.44 MiB 1.58 MiB
cf443d2 5.53 MiB 6.00 MiB 479.99 KiB
81f83eb 7.86 MiB 9.44 MiB 1.58 MiB
73a3c38 7.86 MiB 9.44 MiB 1.58 MiB
54acf91 20.70 MiB 22.46 MiB 1.75 MiB
a10aff4 5.53 MiB 6.00 MiB 486.71 KiB
32914d8 7.86 MiB 9.44 MiB 1.58 MiB
7b21e8b 5.53 MiB 6.00 MiB 479.96 KiB

Previous results on branch: enh/app-start-refresh-rate-jni-ffi

Startup times

Revision Plain With Sentry Diff
9733bc8 1253.72 ms 1255.35 ms 1.63 ms
7750213 1233.76 ms 1232.27 ms -1.49 ms
1ffba6f 1260.40 ms 1259.80 ms -0.60 ms
2cd6dd8 1246.53 ms 1256.00 ms 9.47 ms
91b0298 1255.78 ms 1255.62 ms -0.15 ms
dee9256 1246.90 ms 1247.86 ms 0.96 ms
60f9674 1252.28 ms 1254.39 ms 2.11 ms
143414f 1258.28 ms 1259.59 ms 1.32 ms
9912628 1253.45 ms 1257.18 ms 3.74 ms
99b5584 1253.11 ms 1245.13 ms -7.98 ms

App size

Revision Plain With Sentry Diff
9733bc8 5.53 MiB 6.00 MiB 487.13 KiB
7750213 5.53 MiB 6.00 MiB 485.45 KiB
1ffba6f 5.53 MiB 6.00 MiB 485.46 KiB
2cd6dd8 5.53 MiB 6.00 MiB 485.45 KiB
91b0298 5.53 MiB 6.00 MiB 485.46 KiB
dee9256 5.53 MiB 6.00 MiB 487.14 KiB
60f9674 5.53 MiB 6.00 MiB 485.47 KiB
143414f 5.53 MiB 6.00 MiB 485.46 KiB
9912628 5.53 MiB 6.00 MiB 487.14 KiB
99b5584 5.53 MiB 6.00 MiB 485.46 KiB

cursor[bot]

This comment was marked as outdated.

@buenaflor buenaflor requested a review from denrase October 16, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FFI/JNI Refactor]: App start and refresh rate

2 participants