-
-
Notifications
You must be signed in to change notification settings - Fork 276
Refactor app hang and native crash apis to FFI/JNI #3289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: enh/app-start-refresh-rate-jni-ffi
Are you sure you want to change the base?
Refactor app hang and native crash apis to FFI/JNI #3289
Conversation
🚨 Detected changes in high risk code 🚨High-risk code has higher potential to break the SDK and may be hard to test. To prevent severe bugs, apply the rollout process for releasing such changes and be extra careful when changing and reviewing these files:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## enh/app-start-refresh-rate-jni-ffi #3289 +/- ##
======================================================================
- Coverage 89.12% 88.95% -0.18%
======================================================================
Files 99 99
Lines 3523 3523
======================================================================
- Hits 3140 3134 -6
- Misses 383 389 +6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
7538a1c
to
f881241
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but saw that the nativeCrash method was modified in #3293, just making sure this all fits together.
yup, update it here as well |
📜 Description
Part of FFI/JNI refactors
💡 Motivation and Context
Closes #3207
💚 How did you test it?
Unit test, manual tests
📝 Checklist
sendDefaultPii
is enabled🔮 Next steps