avoid raising on bad dsn #218
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #194
Previously, we'd raise if the DSN was not in the correct format (for whatever reason). This could be considered a bug, as we avoid raising while trying to send events otherwise.
Related to this, we also raise in these places:
sentry-elixir/lib/sentry/client.ex
Line 226 in f88b9bf
sentry-elixir/lib/sentry/client.ex
Line 211 in f88b9bf
For consistency, we should likely avoid raising there as well I think?