Skip to content

Conversation

mitchellhenke
Copy link
Contributor

closes #194

Previously, we'd raise if the DSN was not in the correct format (for whatever reason). This could be considered a bug, as we avoid raising while trying to send events otherwise.

Related to this, we also raise in these places:

raise ArgumentError, message: ":before_send_event must be an anonymous function or a {Module, Function} tuple"

raise ArgumentError, message: ":after_send_event must be an anonymous function or a {Module, Function} tuple"

For consistency, we should likely avoid raising there as well I think?

@mitchellhenke mitchellhenke force-pushed the avoid-raising-on-bad-dsn branch from f88b9bf to b5dcf4a Compare November 20, 2017 15:28
@mitchellhenke mitchellhenke force-pushed the avoid-raising-on-bad-dsn branch from b5dcf4a to 1052ab2 Compare February 6, 2018 18:12
@mitchellhenke mitchellhenke force-pushed the avoid-raising-on-bad-dsn branch from d3720c6 to 427c3c7 Compare February 28, 2018 15:08
@mitchellhenke mitchellhenke force-pushed the avoid-raising-on-bad-dsn branch 3 times, most recently from ea29ae2 to f9c3835 Compare February 28, 2018 15:51
@mitchellhenke mitchellhenke force-pushed the avoid-raising-on-bad-dsn branch 2 times, most recently from 00e2ab5 to e95a163 Compare February 28, 2018 16:52
@mitchellhenke mitchellhenke merged commit 4d159eb into master Feb 28, 2018
@mitchellhenke mitchellhenke deleted the avoid-raising-on-bad-dsn branch February 28, 2018 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid raising on malformed DSN
1 participant