Skip to content

Conversation

schneiderderek
Copy link
Contributor

@schneiderderek schneiderderek commented Jan 31, 2019

We're running into 2 issues:

The first where :inet.ntoa() is returning {:error, :einval} causing the |> to_string call to blow up. This change checks the return of :inet.ntoa/1 before passing it to to_string/1 to avoid the above situation.

The second where Plug.Conn.get_peer_data is returning an error tuple.

@schneiderderek schneiderderek changed the title Avoid an error when inet.ntoa/1 returns an error tuple Avoid an error when formatting remote data Jan 31, 2019
@mitchellhenke
Copy link
Contributor

mitchellhenke commented Jan 31, 2019

Thank you for the contribution! 💖

@mitchellhenke mitchellhenke merged commit d29dc11 into getsentry:master Jan 31, 2019
@schneiderderek schneiderderek deleted the dschneider/fix-build-request-interface branch January 31, 2019 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants