Allow configuration of Sentry log level #334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitchellhenke
suggested changes
Apr 16, 2019
There was a problem hiding this comment.
Huge thanks for opening this PR @halostatue! 🙂
It looks really good overall, and I've left a few of comments on changes if you'd like to handle them. If not, I can likely take care of them by the end of the week.
Thanks again!
mitchellhenke
suggested changes
Apr 16, 2019
mitchellhenke
approved these changes
Apr 17, 2019
|
Hopefully we can get a release soon that includes this so that I can start silencing some of our noisier errors on a spike and reporting the errors we care about (we’re getting a number of JSON encoding errors because of tuples in our data that we can’t quite localize). |
|
@halostatue just published |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements the feature of #304
Because
Loggerhas explicit permitted macro levels, I’ve put in some validation.We’re currently experiencing periodic spike protection and the Sentry logging is also causing some spiking on our log service, too (and because of the
?\nin the log, each Sentry send failure is taking up three log lines). I’d like to handle such logging throughafter_send_event.