Skip to content

Conversation

whatyouhide
Copy link
Collaborator

No description provided.

@whatyouhide whatyouhide merged commit b197090 into master Mar 24, 2024
@whatyouhide whatyouhide deleted the al/oban-capture-errors branch March 24, 2024 17:57
@sorentwo
Copy link

@whatyouhide Once this is released you should come by and add mention of it to the Oban docs 🙂

@michallepicki
Copy link
Contributor

Hi @whatyouhide , thank you for this! I have custom instrumentation already and comparing it to the code from this PR it looks more straightforward. I wonder e.g. why did you decide not to use the stacktrace and other fields from meta which are exposed for error reporting purposes as Oban documents here? And would you care to explain in what scenarios the stacktrace could be empty and why it's important to fill it in with something?

@sorentwo
Copy link

@michallepicki there are details about why the stacktrace is empty and other tidbits in this article: https://getoban.pro/articles/enhancing-error-reporting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants