Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lib/sentry/context.ex
Original file line number Diff line number Diff line change
Expand Up @@ -423,8 +423,7 @@ defmodule Sentry.Context do
sentry_metadata =
get_sentry_context()
|> Map.update(@breadcrumbs_key, [map], fn breadcrumbs ->
breadcrumbs = [map | breadcrumbs]
Enum.take(breadcrumbs, -1 * Sentry.Config.max_breadcrumbs())
Enum.take([map | breadcrumbs], Sentry.Config.max_breadcrumbs())
end)

:logger.update_process_metadata(%{@logger_metadata_key => sentry_metadata})
Expand Down
10 changes: 10 additions & 0 deletions test/context_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,16 @@ defmodule Sentry.ContextTest do
assert first_breadcrumb.timestamp <= second_breadcrumb.timestamp
end

test "retains most recent breadcrumbs when exceeding max" do
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test fails on master.

put_test_config(max_breadcrumbs: 3)

for x <- 1..10, do: Context.add_breadcrumb(message: x)

event = Event.create_event([])

assert event.breadcrumbs |> Enum.map(& &1.message) == [8, 9, 10]
end

test "storing user context appears when generating event" do
Context.set_user_context(%{id: "345"})

Expand Down
Loading