Remain compatible with new translation format to be introduced in Elixir 1.19 #885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martosaur
commented
May 2, 2025
test/sentry/logger_handler_test.exs
Outdated
| assert [exception] = event.exception | ||
| assert exception.type == "KeyError" | ||
| assert exception.value == "key :foo not found in: []" | ||
| assert exception.value == "key :foo not found in:\n\n []" |
There was a problem hiding this comment.
That's unrelated to the translation: elixir-lang/elixir#14269
martosaur
force-pushed
the
am-handle-1.19-translations
branch
from
81ea297 to
ae9b9e5
Compare
martosaur
force-pushed
the
am-handle-1.19-translations
branch
from
ae9b9e5 to
d136ad2
Compare
|
I think this is totally fine for the time being. Great catch, thank you @martosaur 💟 |
whatyouhide
approved these changes
May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋
Elixir 1.19 will change how log translation works. Instead of replacing structured reports elixir will inject string translation into the report and wrap the
report_cbcallback. This enables logging libraries like Sentry to access report data directly instead of parsing iodata like they do now. But it also breaks the parsing.This PR introduces a bare minimum change to make Sentry work with the new translations – whenever we detect a report with
elixir_translationkey, we replace the report with the translation, effectively restoring pre-1.19 behaviour.Feel free to close this PR and replace it with a more sophisticated solution that takes advantage of the new structure 🙏