Skip to content

Tweak credit card regex handling for OTP-28 #898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 28, 2025
Merged

Tweak credit card regex handling for OTP-28 #898

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
20f7e75
Tweak credit card regex handling for OTP-28
solnic May 27, 2025
e56f41b
Update CHANGELOG
solnic May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## Unreleased

- Tweak credit card regex handling for OTP-28 ([#898](https://github.com/getsentry/sentry-elixir/pull/898))

# Changelog

## 10.10.0
Expand Down
5 changes: 3 additions & 2 deletions lib/sentry/plug_context.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,6 @@ defmodule Sentry.PlugContext do

@default_scrubbed_param_keys ["password", "passwd", "secret"]
@default_scrubbed_header_keys ["authorization", "authentication", "cookie"]
@credit_card_regex ~r/^(?:\d[ -]*?){13,16}$/
@scrubbed_value "*********"
@default_plug_request_id_header "x-request-id"

Expand Down Expand Up @@ -277,7 +276,7 @@ defmodule Sentry.PlugContext do
value =
cond do
key in scrubbed_keys -> @scrubbed_value
is_binary(value) and value =~ @credit_card_regex -> @scrubbed_value
is_binary(value) and value =~ credit_card_regex() -> @scrubbed_value
is_struct(value) -> value |> Map.from_struct() |> scrub_map(scrubbed_keys)
is_map(value) -> scrub_map(value, scrubbed_keys)
is_list(value) -> scrub_list(value, scrubbed_keys)
Expand All @@ -298,4 +297,6 @@ defmodule Sentry.PlugContext do
end
end)
end

defp credit_card_regex, do: ~r/^(?:\d[ -]*?){13,16}$/
end