Fix do not initialize SDK for Jetpack Compose Preview builds #4324
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markushi
requested review from
adinauer,
lcian,
romtsn and
stefanosiano
as code owners
Contributor
Performance metrics 🚀
|
romtsn
reviewed
Apr 9, 2025
| // Jetpack Compose Preview (aka "Run Preview on Device") | ||
| // uses the androidTest flavor for android library modules, | ||
| // so let's fail-fast by checking this first | ||
| if (context.getPackageName().endsWith(".test")) { |
Member
There was a problem hiding this comment.
I think this will cover the majority of customers already, great find 💯
romtsn
reviewed
Apr 9, 2025
sentry-android-core/src/main/java/io/sentry/android/core/SentryInitProvider.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
If you launch a Jetpack Compose Preview for a
@Composablewithin a library, the library will be packaged as an app (androidTestflavor) and the Compose Tooling will add a preview activity.If the library has a dependency to Sentry, this will cause the preview-app to crash, as typically no DSN is set within the library and our SDK will try to auto-init.
There's no easy way around this, but we can detect at runtime if the app is a preview app.
💡 Motivation and Context
Fixes #2904
💚 How did you test it?
Added unit tests.
📝 Checklist
sendDefaultPIIis enabled.🔮 Next steps