Skip to content

Conversation

@adinauer
Copy link
Member

📜 Description

Do not use Sentry logging API if logs are disabled for JUL

💡 Motivation and Context

Same problem reported for Log4j2 also applies to JUL (#4573)

💚 How did you test it?

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Jul 29, 2025

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 512.50 ms 581.56 ms 69.06 ms
Size 1.58 MiB 2.09 MiB 519.50 KiB

Previous results on branch: fix/reduce-noop-warnings-for-jul

Startup times

Revision Plain With Sentry Diff
fb69e30 448.20 ms 505.44 ms 57.24 ms

App size

Revision Plain With Sentry Diff
fb69e30 1.58 MiB 2.09 MiB 519.49 KiB

@adinauer adinauer merged commit 34f4b72 into main Jul 29, 2025
35 of 36 checks passed
@adinauer adinauer deleted the fix/reduce-noop-warnings-for-jul branch July 29, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants