Node: Express not reporting ip address by default

[chris-smith-zocdoc]

Package + Version

• @sentry/browser
• @sentry/node
• raven-js
• raven-node (raven for node)
• other:

Version:

5.12.5

Description

Sentry isn't reporting the ipAddress by default with the node integration. Because of this check

sentry-javascript/packages/node/src/handlers.ts

Lines 263 to 268 in f001435

	if (options.user && req.user) {
	event.user = {
	...event.user,
	...extractUserData(req, options.user),
	};
	}

it requires the user to be set on the request. If this is intended behavior, it should be called out on the node docs. On the old Raven sdk, this was reported by default.

[kamilogorek]

Sent a PR that will allow to extract the IP without the necessity of req.user existence. However, it'll still be required to turn it on manually (docs PR also included), as we have now more rules about PII and sensitive data stripping.

#2467
getsentry/sentry-docs#1525

[kamilogorek]

Closing the issue as a part of large repository cleanup, due to it being inactive and/or outdated.
Please do not hesitate to ping me if it is still relevant, and I will happily reopen and work on it.
Cheers!