feat(v8): Delete @sentry/hub #10530
Merged
feat(v8): Delete @sentry/hub #10530
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
Lms24 and
mydea
and removed request for
a team
mydea
force-pushed
the
abhi-delete-hub
branch
from
14fa05d to
023c65a
Compare
|
I wonder if we should hold off with that, just to avoid f**ing with craft releases? 🤔 |
AbhiPrasad
force-pushed
the
abhi-delete-hub
branch
from
023c65a to
c460908
Compare
mydea
approved these changes
Feb 8, 2024
Lms24
added a commit
that referenced
this pull request
Feb 14, 2024
Since we deleted `@sentry/hub` in #10530, we also removed the craft NPM target for the hub package. Given that the craft config is always taken from `develop` (generally, the default branch of the repository), Craft no longer published `@sentry/hub` when we cut a release from our `v7` branch. Unfortunately, the NPM target does not support an optional `onlyIfPresent` configuration, meaning for now, we have to continue publishing a `@sentry/hub` placeholder package when we cut a release from `develop` (i.e. our v8 branch at the moment).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5665
Goodbye hub package, I've known you my whole (sentry) life.
Moved tests into core where applicable, otherwise deleted tests that were redundant.