fix(nextjs): add next 12 to the list of peer deps #4106
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closes #4105 |
|
the tests didn't catch this issue because they use yarn instead of a newer version of npm |
|
Hey @MKrupauskas thanks for the contribution! This is a duplicate of #4093, so we are going to close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
npm i with the new version of next (^12.0) is failing because of @sentry/nextjs because the defined valid peer dependencies for next do not include version 12, see full error below. To mitigate this I've created a PR to add next 12 to the valid peer deps list. This change will need a package version release. Note: the install works with npm i --legacy-peer-deps which ignores peer deps.