meta: 7.0.0-beta.0 CHANGELOG #5011
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
AbhiPrasad
force-pushed
the
v7-7.0.0-beta.0-changelog
branch
from
7327b64 to
1ff254e
Compare
AbhiPrasad
force-pushed
the
v7-7.0.0-beta.0-changelog
branch
from
1ff254e to
7854fa1
Compare
|
Blocked by #5015 |
yordis
suggested changes
Apr 28, 2022
MIGRATION.md
Outdated
| import { stackParserFromOptions } from '@sentry/utils'; | ||
|
|
||
| // New in v7: | ||
| const client = BrowserClient({ |
There was a problem hiding this comment.
I would be careful using PascalCase naming when the intention is doing a function call.
It is easy to miss that they are technically functions and assume that they are constructors and people adding new BrowserClient(...). And the worst is that it is "technically correct" from the perspective of the runtime (but wrong based on the usage, and intention).
I will recommend to do makeBrowserClient or browserClient or newBrowserClient but avoid PascalCase.
There was a problem hiding this comment.
yup, this is my bad. BrowserClient is still a class for now - so there should be the new keyword here - we'll maybe revisit this at a later time though,
AbhiPrasad
commented
May 3, 2022
AbhiPrasad
requested review from
a team,
Lms24 and
lforst
and removed request for
a team
Lms24
approved these changes
May 3, 2022
AbhiPrasad
added a commit
that referenced
this pull request
May 30, 2022
Co-authored-by: Luca Forstner <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CHANGELOG for the v7 beta!