test(e2e): Add standard frontend test app specification #5874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lforst
force-pushed
the
lforst-standard-frontend-application-e2e-setup-guide
branch
from
0857a22 to
da6a8f5
Compare
lforst
commented
Oct 3, 2022
| `standard-frontend-nextjs`. | ||
| - A page at path `/` | ||
| - Having a `<input type="button" id="exception-button">` that captures an Exception when clicked. The returned | ||
| `eventId` from the `Sentry.captureException()` call must be written to `window.capturedExceptionId`. It doesn not |
There was a problem hiding this comment.
We write it to window.capturedExceptionId so we can read it with playwrights waitForFunction https://playwright.dev/docs/api/class-page#page-wait-for-function
2 tasks
added 3 commits
October 3, 2022 13:19
…ntend-application-e2e-setup-guide
Lms24
approved these changes
Oct 3, 2022
packages/e2e-tests/README.md
Outdated
|
|
||
| ## Standardized Test Apps | ||
|
|
||
| For some of our integration tests we define a standard for test applications as to how they should look and behave. |
There was a problem hiding this comment.
Shouldn't this be "end-to-end" tests?
added 2 commits
October 3, 2022 14:41
Correct, I will add the actual tests in a follow-up PR. As for release health: Thanks for reminding me, I thought we were good on that front but I needed to add a release value so that sessions are sent. :) |
lforst
deleted the
lforst-standard-frontend-application-e2e-setup-guide
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: #5855
Adds a specification on how to configure standardized frontend test applications for our E2E tests and also adds a React test application that conforms to that standard.