feat(tracing): Add tracePropagationTargets option to browser routing instrumentation
#6080
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 28, 2022
size-limit report 📦
|
Lms24
approved these changes
Oct 28, 2022
Base automatically changed from
kmclb-fix-tracingOrigins-not-applying
to
master
October 28, 2022 07:18
|
I'd love this ASAP because we're currently unable to use Sentry on the browser with rejected CORS from 3rd party requests. |
|
@cdbattags did the 7.17.2 patch release not fix this for you? |
lobsterkatie
force-pushed
the
kmclb-add-tracePropagationTargets-to-browserTracing
branch
from
b571e79 to
59c8016
Compare
lobsterkatie
changed the title
tracePropagationTargets option to browser tracingtracePropagationTargets option to browser routing instrumentation
lobsterkatie
deleted the
kmclb-add-tracePropagationTargets-to-browserTracing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the work on #5285, this adds a new option,
tracePropagationTargets, to our browser-side tracing instrumentation, to live alongside (and eventually take the place of)tracingOrigins. Its behavior matches that oftracingOrigins, but it has a much clearer name.Switching from internal use of
tracingOriginstotracePropagationTargetsto come in future PRs.Note: This is what remained of #6041 after the fix in #6079 was split off. h/t @timfish for the initial work in that PR.