chore: Move sample-new-arch to samples/react-native (#3425)

Author: krystofwoldrich

.eslintignore

@@ -2,7 +2,7 @@
 dist
 
 # Ignore standalone apps
-sample-new-architecture
+samples/react-native
 test/perf/TestApp*
 
 # Ignore dangerfile

.github/workflows/buildandtest.yml

@@ -51,15 +51,15 @@ jobs:
       - uses: actions/cache@v3
         id: cache
         with:
-          path: sample-new-architecture/node_modules
+          path: samples/react-native/node_modules
           key: ${{ runner.os }}-${{ github.sha }}
       - name: Install Dependencies
         if: steps.cache.outputs['cache-hit'] != 'true'
         run: yarn install
-        working-directory: sample-new-architecture
+        working-directory: samples/react-native
       - name: Lint Sample
         run: yarn lint
-        working-directory: sample-new-architecture
+        working-directory: samples/react-native
 
   job_check_integrity:
     name: Check package integrity
@@ -180,20 +180,20 @@ jobs:
         uses: actions/cache@v3
         id: cache-sample
         with:
-          path: sample-new-architecture/node_modules
-          key: ${{ runner.os }}-${{ hashFiles('sample-new-architecture/yarn.lock') }}
+          path: samples/react-native/node_modules
+          key: ${{ runner.os }}-${{ hashFiles('samples/react-native/yarn.lock') }}
       - name: Install Dependencies
         if: ${{ steps.cache.outputs['cache-hit'] != 'true' }}
         run: yarn install
       - name: Install Sample Dependencies
         if: ${{ steps.cache-sample.outputs['cache-hit'] != 'true' }}
         run: yarn install
-        working-directory: sample-new-architecture
+        working-directory: samples/react-native
       - name: Build
         run: yarn build
       - name: Make Sample Build Directory
         run: mkdir build
-        working-directory: sample-new-architecture
+        working-directory: samples/react-native
       - name: Bundle
         run: |
           yarn run react-native bundle \
@@ -203,4 +203,4 @@ jobs:
           --reset-cache \
           --bundle-output build/bundle.${{ matrix.platform }}.js \
           --sourcemap-output build/bundle.${{ matrix.platform }}.map
-        working-directory: sample-new-architecture
+        working-directory: samples/react-native

.github/workflows/codegen.yml

@@ -16,11 +16,11 @@ jobs:
         include:
           - platform: android
             command: |
-              cd sample-new-architecture/android
+              cd samples/react-native/android
               ./gradlew generateCodegenArtifactsFromSchema
           - platform: ios
             command: |
-              cd sample-new-architecture/ios
+              cd samples/react-native/ios
               node ../node_modules/react-native/scripts/generate-codegen-artifacts.js \
                 --path .. \
                 --outputPath codegen
@@ -32,12 +32,12 @@ jobs:
       - uses: actions/cache@v3
         id: cache
         with:
-          path: sample-new-architecture/node_modules
+          path: samples/react-native/node_modules
           key: ${{ runner.os }}-${{ github.sha }}
       - name: Install Dependencies
         if: steps.cache.outputs['cache-hit'] != 'true'
         run: |
-          cd sample-new-architecture
+          cd samples/react-native
           yarn install
       - name: Codegen
         run: ${{ matrix.command }}

.github/workflows/sample-application.yml

@@ -43,7 +43,7 @@ jobs:
       - uses: ruby/setup-ruby@v1
         if: ${{ matrix.platform == 'ios' }}
         with:
-          working-directory: sample-new-architecture
+          working-directory: samples/react-native
           ruby-version: '3.2.2' # based on what is used in the sample
           bundler-cache: true # runs 'bundle install' and caches installed gems automatically
 
@@ -61,8 +61,8 @@ jobs:
         with:
           path: |
             node_modules
-            sample-new-architecture/node_modules
-          key: ${{ github.workflow }}-${{ github.job }}-npm-${{ hashFiles('yarn.lock', 'sample-new-architecture/yarn.lock') }}
+            samples/react-native/node_modules
+          key: ${{ github.workflow }}-${{ github.job }}-npm-${{ hashFiles('yarn.lock', 'samples/react-native/yarn.lock') }}
 
       - name: Install SDK Dependencies
         if: ${{ steps.deps-cache.outputs['cache-hit'] != 'true' }}
@@ -73,12 +73,12 @@ jobs:
 
       - name: Install Sample Dependencies
         if: ${{ steps.deps-cache.outputs['cache-hit'] != 'true' }}
-        working-directory: sample-new-architecture
+        working-directory: samples/react-native
         run: yarn install
 
       - name: Install App Pods
         if: ${{ matrix.platform == 'ios' }}
-        working-directory: sample-new-architecture/ios
+        working-directory: samples/react-native/ios
         run: |
           [[ "${{ matrix.build-type }}" == "production" ]] && ENABLE_PROD=1 || ENABLE_PROD=0
           [[ "${{ matrix.rn-architecture }}" == "new" ]] && ENABLE_NEW_ARCH=1 || ENABLE_NEW_ARCH=0
@@ -89,7 +89,7 @@ jobs:
 
       - name: Build Android App
         if: ${{ matrix.platform == 'android' }}
-        working-directory: sample-new-architecture/android
+        working-directory: samples/react-native/android
         run: |
           if [[ ${{ matrix.rn-architecture }} == 'new' ]]; then
             perl -i -pe's/newArchEnabled=false/newArchEnabled=true/g' gradle.properties
@@ -101,7 +101,7 @@ jobs:
 
       - name: Build iOS App
         if: ${{ matrix.platform == 'ios' }}
-        working-directory: sample-new-architecture/ios
+        working-directory: samples/react-native/ios
         run: |
           [[ "${{ matrix.build-type }}" == "production" ]] && CONFIG='Release' || CONFIG='Debug'
           echo "Building $CONFIG"
@@ -123,4 +123,4 @@ jobs:
         uses: actions/upload-artifact@v3
         with:
           name: build-sample-${{ matrix.rn-architecture }}-${{ matrix.platform }}-${{ matrix.build-type }}-logs
-          path: sample-new-architecture/ios/*.log
+          path: samples/react-native/ios/*.log

.vscode/settings.json

@@ -23,6 +23,6 @@
     "editor.formatOnPaste": false,
     "editor.formatOnSave": false
   },
-  "react-native-tools.projectRoot": "./sample-new-architecture",
+  "react-native-tools.projectRoot": "./samples/sample-new-architecture",
   "dart.flutterAdbConnectOnChromeOs": false
 }

CONTRIBUTING.md

@@ -34,8 +34,8 @@
     "lint:eslint": "eslint --config .eslintrc.js .",
     "lint:prettier": "prettier --check \"{src,test,scripts}/**/**.ts\"",
     "test:watch": "jest --watch",
-    "run-ios": "cd sample-new-architecture && yarn react-native run-ios",
-    "run-android": "cd sample-new-architecture && yarn react-native run-android",
+    "run-ios": "cd samples/react-native && yarn react-native run-ios",
+    "run-android": "cd samples/react-native && yarn react-native run-android",
     "yalc:add:sentry-javascript": "yalc add @sentry/browser @sentry/core @sentry/hub @sentry/integrations @sentry/react @sentry/types @sentry/utils"
   },
   "keywords": [