chore: Move `sample-new-arch` to `samples/react-native` #3425

krystofwoldrich · 2023-11-27T22:10:40Z

📢 Type of change

Refactoring

📜 Description

This PR moves sample-new-architecture to samples/react-native in preparation for new samples. Namely expo managed app.

💚 How did you test it?

ci

📝 Checklist

I reviewed submitted code
I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
All tests passing
No breaking changes

🔮 Next steps

#skip-changelog

github-actions · 2023-11-27T22:25:13Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	394.51 ms	422.57 ms	28.06 ms
Size	17.73 MiB	19.84 MiB	2.11 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`e5c9b8b`	409.02 ms	426.66 ms	17.64 ms
`d0bf494`+dirty	375.37 ms	395.14 ms	19.77 ms
`575f9da`	415.26 ms	422.98 ms	7.72 ms
`0db0c72`	372.12 ms	386.00 ms	13.88 ms
`e73f4ed`+dirty	332.96 ms	354.33 ms	21.37 ms
`acadc0f`+dirty	373.24 ms	381.51 ms	8.27 ms
`8900e1a`+dirty	430.68 ms	456.13 ms	25.44 ms
`3ffcddd`	302.92 ms	315.80 ms	12.88 ms
`d361d38`	354.10 ms	381.69 ms	27.59 ms
`f06c879`	408.41 ms	424.54 ms	16.13 ms

App size

Revision	Plain	With Sentry	Diff
`e5c9b8b`	17.73 MiB	19.83 MiB	2.10 MiB
`d0bf494`+dirty	17.73 MiB	19.75 MiB	2.02 MiB
`575f9da`	17.73 MiB	19.83 MiB	2.10 MiB
`0db0c72`	17.73 MiB	19.75 MiB	2.02 MiB
`e73f4ed`+dirty	17.73 MiB	20.04 MiB	2.31 MiB
`acadc0f`+dirty	17.73 MiB	19.75 MiB	2.01 MiB
`8900e1a`+dirty	17.73 MiB	19.75 MiB	2.01 MiB
`3ffcddd`	17.73 MiB	19.75 MiB	2.02 MiB
`d361d38`	17.73 MiB	19.81 MiB	2.08 MiB
`f06c879`	17.73 MiB	19.85 MiB	2.12 MiB

Previous results on branch: kw-move-sample-to-samples

Startup times

Revision	Plain	With Sentry	Diff
`f4907af`	429.10 ms	451.32 ms	22.22 ms

App size

Revision	Plain	With Sentry	Diff
`f4907af`	17.73 MiB	19.84 MiB	2.11 MiB

github-actions · 2023-11-28T10:10:47Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	337.27 ms	355.53 ms	18.27 ms
Size	7.15 MiB	8.11 MiB	987.03 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`d0bf494`+dirty	253.73 ms	308.23 ms	54.49 ms
`3853f43`+dirty	278.12 ms	338.72 ms	60.60 ms
`e73f4ed`+dirty	262.98 ms	311.02 ms	48.04 ms
`9c48b2c`+dirty	270.82 ms	321.12 ms	50.30 ms
`27ef4ee`+dirty	296.71 ms	351.00 ms	54.29 ms
`6e8584e`+dirty	383.37 ms	400.84 ms	17.47 ms
`acadc0f`+dirty	259.04 ms	304.67 ms	45.63 ms
`8900e1a`+dirty	371.40 ms	377.70 ms	6.31 ms
`e2b64fe`+dirty	258.82 ms	304.26 ms	45.44 ms
`e5c9b8b`+dirty	335.40 ms	360.06 ms	24.67 ms

App size

Revision	Plain	With Sentry	Diff
`d0bf494`+dirty	7.15 MiB	8.04 MiB	910.85 KiB
`3853f43`+dirty	7.15 MiB	8.08 MiB	959.34 KiB
`e73f4ed`+dirty	7.15 MiB	8.09 MiB	965.94 KiB
`9c48b2c`+dirty	7.15 MiB	8.07 MiB	947.16 KiB
`27ef4ee`+dirty	7.15 MiB	8.08 MiB	959.49 KiB
`6e8584e`+dirty	7.15 MiB	8.13 MiB	1002.18 KiB
`acadc0f`+dirty	7.15 MiB	8.03 MiB	903.20 KiB
`8900e1a`+dirty	7.15 MiB	8.03 MiB	901.79 KiB
`e2b64fe`+dirty	7.15 MiB	8.07 MiB	947.16 KiB
`e5c9b8b`+dirty	7.15 MiB	8.10 MiB	980.41 KiB

github-actions · 2023-11-28T19:52:31Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1300.10 ms	1313.04 ms	12.94 ms
Size	2.36 MiB	2.87 MiB	521.03 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`d0bf494`+dirty	1289.40 ms	1298.40 ms	9.00 ms
`3853f43`+dirty	1221.82 ms	1242.64 ms	20.82 ms
`e73f4ed`+dirty	1243.27 ms	1244.52 ms	1.25 ms
`9c48b2c`+dirty	1246.96 ms	1255.73 ms	8.77 ms
`27ef4ee`+dirty	1293.52 ms	1296.08 ms	2.56 ms
`6e8584e`+dirty	1274.50 ms	1296.82 ms	22.32 ms
`acadc0f`+dirty	1264.38 ms	1290.06 ms	25.68 ms
`8900e1a`+dirty	1210.27 ms	1218.66 ms	8.39 ms
`e2b64fe`+dirty	1232.22 ms	1255.20 ms	22.98 ms
`e5c9b8b`+dirty	1258.57 ms	1267.32 ms	8.75 ms

App size

Revision	Plain	With Sentry	Diff
`d0bf494`+dirty	2.36 MiB	2.83 MiB	481.15 KiB
`3853f43`+dirty	2.36 MiB	2.85 MiB	499.81 KiB
`e73f4ed`+dirty	2.36 MiB	2.82 MiB	469.44 KiB
`9c48b2c`+dirty	2.36 MiB	2.85 MiB	495.77 KiB
`27ef4ee`+dirty	2.36 MiB	2.85 MiB	500.03 KiB
`6e8584e`+dirty	2.36 MiB	2.88 MiB	533.17 KiB
`acadc0f`+dirty	2.36 MiB	2.83 MiB	480.37 KiB
`8900e1a`+dirty	2.36 MiB	2.83 MiB	479.25 KiB
`e2b64fe`+dirty	2.36 MiB	2.85 MiB	495.80 KiB
`e5c9b8b`+dirty	2.36 MiB	2.87 MiB	520.43 KiB

Previous results on branch: kw-move-sample-to-samples

Startup times

Revision	Plain	With Sentry	Diff
`f4907af`+dirty	1281.60 ms	1291.35 ms	9.75 ms

App size

Revision	Plain	With Sentry	Diff
`f4907af`+dirty	2.36 MiB	2.87 MiB	521.02 KiB

github-actions · 2023-11-28T19:53:36Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1255.00 ms	1256.86 ms	1.86 ms
Size	2.92 MiB	3.43 MiB	524.92 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`d0bf494`+dirty	1266.20 ms	1267.52 ms	1.32 ms
`3853f43`+dirty	1271.74 ms	1278.04 ms	6.30 ms
`e73f4ed`+dirty	1282.90 ms	1309.30 ms	26.40 ms
`9c48b2c`+dirty	1253.39 ms	1256.30 ms	2.91 ms
`27ef4ee`+dirty	1236.41 ms	1244.90 ms	8.49 ms
`6e8584e`+dirty	1271.71 ms	1281.26 ms	9.55 ms
`acadc0f`+dirty	1271.12 ms	1272.28 ms	1.16 ms
`8900e1a`+dirty	1268.36 ms	1273.04 ms	4.68 ms
`e2b64fe`+dirty	1285.78 ms	1297.56 ms	11.78 ms
`e5c9b8b`+dirty	1276.90 ms	1280.92 ms	4.02 ms

App size

Revision	Plain	With Sentry	Diff
`d0bf494`+dirty	2.92 MiB	3.40 MiB	488.08 KiB
`3853f43`+dirty	2.92 MiB	3.41 MiB	503.54 KiB
`e73f4ed`+dirty	2.92 MiB	3.38 MiB	475.71 KiB
`9c48b2c`+dirty	2.92 MiB	3.41 MiB	499.97 KiB
`27ef4ee`+dirty	2.92 MiB	3.41 MiB	503.72 KiB
`6e8584e`+dirty	2.92 MiB	3.44 MiB	536.52 KiB
`acadc0f`+dirty	2.92 MiB	3.39 MiB	487.34 KiB
`8900e1a`+dirty	2.92 MiB	3.39 MiB	485.96 KiB
`e2b64fe`+dirty	2.92 MiB	3.41 MiB	499.97 KiB
`e5c9b8b`+dirty	2.92 MiB	3.43 MiB	524.50 KiB

Previous results on branch: kw-move-sample-to-samples

Startup times

Revision	Plain	With Sentry	Diff
`f4907af`+dirty	1282.14 ms	1282.76 ms	0.62 ms

App size

Revision	Plain	With Sentry	Diff
`f4907af`+dirty	2.92 MiB	3.43 MiB	524.94 KiB

lucas-zimerman

Two small issues but other than that looks good to me !

contributing.md contains sample-new-architecture on a github link

### Run the emulators (legacy-architecture):

For android switch `newArchEnabled` to `false` in [android/gradle.properties](https://github.com/getsentry/sentry-react-native/blob/c95aa21497ca93aaaaf0b44d170dc39dc7bcf660/sample-new-architecture/android/gradle.properties#L40). For iOS explicitly disable fabric in `samples/react-native/ios/Podfile` by setting `:fabric_enabled => false` before `pod install`.

On settings.json, there's a reference to the old project.

  "react-native-tools.projectRoot": "./samples/sample-new-architecture",

philipphofmann

LGTM

chore: Move sample-new-arch to samples/react-native

abc65df

Fix paths to repo root

f90f417

fix paths

5d689ed

krystofwoldrich requested review from brustolin, buenaflor and philipphofmann November 28, 2023 14:39

krystofwoldrich marked this pull request as ready for review November 28, 2023 14:40

krystofwoldrich requested a review from lucas-zimerman as a code owner November 28, 2023 14:40

fix sentry-cli path ios

2612051

Fix xcode build phases paths

0f7c613

krystofwoldrich self-assigned this Nov 29, 2023

lucas-zimerman approved these changes Nov 29, 2023

View reviewed changes

philipphofmann approved these changes Nov 29, 2023

View reviewed changes

krystofwoldrich merged commit 4367b7a into main Nov 30, 2023

krystofwoldrich deleted the kw-move-sample-to-samples branch November 30, 2023 13:49

krystofwoldrich mentioned this pull request Dec 5, 2023

fix(xcode): Collect modules path from shell #3451

Merged

9 tasks

Uh oh!

chore: Move sample-new-arch to samples/react-native #3425

chore: Move sample-new-arch to samples/react-native #3425

Uh oh!

Conversation

krystofwoldrich commented Nov 27, 2023

📢 Type of change

📜 Description

💚 How did you test it?

📝 Checklist

🔮 Next steps

Uh oh!

github-actions bot commented Nov 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: kw-move-sample-to-samples

Startup times

App size

Uh oh!

github-actions bot commented Nov 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Nov 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: kw-move-sample-to-samples

Startup times

App size

Uh oh!

github-actions bot commented Nov 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Previous results on branch: kw-move-sample-to-samples

Startup times

App size

Uh oh!

lucas-zimerman left a comment

Choose a reason for hiding this comment

Uh oh!

philipphofmann left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

chore: Move `sample-new-arch` to `samples/react-native` #3425

chore: Move `sample-new-arch` to `samples/react-native` #3425

github-actions bot commented Nov 27, 2023 •

edited

Loading

github-actions bot commented Nov 28, 2023 •

edited

Loading

github-actions bot commented Nov 28, 2023 •

edited

Loading

github-actions bot commented Nov 28, 2023 •

edited

Loading