Skip to content

Conversation

@krystofwoldrich
Copy link
Contributor

📢 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

📜 Description

This PR updates the Expo sample to the latest Expo SDK 50 beta 0.

It also adds expo-router and Metro for Web as that's the only supported way to build an Expo Web app in SDK 50.

💚 How did you test it?

build locally

Screenshot 2023-12-12 at 14 27 47

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

#skip-changelog

@krystofwoldrich
Copy link
Contributor Author

Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from kw-remove-rn-internals-from-web to expo December 13, 2023 11:00
@krystofwoldrich krystofwoldrich merged commit 337cd67 into expo Jan 8, 2024
@krystofwoldrich krystofwoldrich deleted the kw-update-expo branch January 8, 2024 10:47
@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2024

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 403.22 ms 417.94 ms 14.71 ms
Size 17.73 MiB 19.84 MiB 2.11 MiB

Baseline results on branch: expo

Startup times

Revision Plain With Sentry Diff
bc4097b 419.25 ms 458.81 ms 39.56 ms

App size

Revision Plain With Sentry Diff
bc4097b 17.73 MiB 19.84 MiB 2.11 MiB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants