fix(breadcrumb-ios): Handle non-string category in getCurrentScreen #4629

krystofwoldrich · 2025-03-05T16:45:08Z

📢 Type of change

Bugfix
New feature
Enhancement
Refactoring

📜 Description

This should never happen the protocol defines category as string. But in js anything can be set.

fixes [__NSCFBoolean isEqualToString:]: unrecognized selector sent to instance #4627 (comment)

💚 How did you test it?

unit tests

📝 Checklist

I added tests to verify changes
No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
I updated the docs if needed.
I updated the wizard if needed.
All tests passing
No breaking changes

github-actions · 2025-03-05T17:09:47Z

Android (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	446.30 ms	460.85 ms	14.55 ms
Size	17.75 MiB	20.12 MiB	2.37 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`5bb8d5f`	431.21 ms	459.40 ms	28.19 ms
`025d490`	365.42 ms	404.48 ms	39.06 ms
`c398f67`	449.64 ms	461.38 ms	11.74 ms
`5f03ae9`	444.88 ms	448.89 ms	4.01 ms
`75774ea`	454.16 ms	467.80 ms	13.64 ms
`d361d38`	354.10 ms	381.69 ms	27.59 ms
`8ae23a7`	526.83 ms	513.38 ms	-13.45 ms
`57448c5`	443.47 ms	440.20 ms	-3.26 ms
`0c98663`	437.75 ms	420.70 ms	-17.05 ms
`40c35c5`	438.38 ms	437.52 ms	-0.86 ms

App size

Revision	Plain	With Sentry	Diff
`5bb8d5f`	17.73 MiB	19.93 MiB	2.20 MiB
`025d490`	17.75 MiB	20.12 MiB	2.37 MiB
`c398f67`	17.73 MiB	19.94 MiB	2.21 MiB
`5f03ae9`	17.75 MiB	20.11 MiB	2.36 MiB
`75774ea`	17.74 MiB	20.08 MiB	2.35 MiB
`d361d38`	17.73 MiB	19.81 MiB	2.08 MiB
`8ae23a7`	17.74 MiB	20.07 MiB	2.34 MiB
`57448c5`	17.74 MiB	20.08 MiB	2.34 MiB
`0c98663`	17.75 MiB	20.12 MiB	2.37 MiB
`40c35c5`	17.75 MiB	20.11 MiB	2.37 MiB

github-actions · 2025-03-05T17:11:47Z

iOS (legacy) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1227.35 ms	1226.59 ms	-0.76 ms
Size	2.63 MiB	3.75 MiB	1.12 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`8bda0cc`+dirty	1221.90 ms	1208.11 ms	-13.79 ms
`80b2ce3`+dirty	1265.92 ms	1268.60 ms	2.69 ms
`31fcca2`+dirty	1209.17 ms	1216.21 ms	7.04 ms
`db44eaf`+dirty	1227.09 ms	1230.65 ms	3.56 ms
`2ec71da`+dirty	1225.85 ms	1231.57 ms	5.72 ms
`e2b64fe`+dirty	1232.22 ms	1255.20 ms	22.98 ms
`8ab11b6`+dirty	1203.23 ms	1206.02 ms	2.79 ms
`1c65324`+dirty	1235.17 ms	1235.08 ms	-0.09 ms
`a0b0298`+dirty	1220.73 ms	1226.87 ms	6.14 ms
`83f6f6c`+dirty	1218.33 ms	1220.27 ms	1.93 ms

App size

Revision	Plain	With Sentry	Diff
`8bda0cc`+dirty	2.63 MiB	3.70 MiB	1.06 MiB
`80b2ce3`+dirty	2.36 MiB	2.84 MiB	486.98 KiB
`31fcca2`+dirty	2.36 MiB	2.90 MiB	552.95 KiB
`db44eaf`+dirty	2.36 MiB	3.10 MiB	755.81 KiB
`2ec71da`+dirty	2.36 MiB	3.13 MiB	784.66 KiB
`e2b64fe`+dirty	2.36 MiB	2.85 MiB	495.80 KiB
`8ab11b6`+dirty	2.36 MiB	3.11 MiB	759.83 KiB
`1c65324`+dirty	2.36 MiB	3.04 MiB	698.64 KiB
`a0b0298`+dirty	2.63 MiB	3.75 MiB	1.12 MiB
`83f6f6c`+dirty	2.36 MiB	3.10 MiB	759.79 KiB

github-actions · 2025-03-05T17:16:20Z

iOS (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	1230.14 ms	1233.47 ms	3.33 ms
Size	3.19 MiB	4.32 MiB	1.13 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`8bda0cc`+dirty	1217.90 ms	1223.02 ms	5.12 ms
`80b2ce3`+dirty	1245.12 ms	1262.04 ms	16.92 ms
`31fcca2`+dirty	1222.04 ms	1226.51 ms	4.47 ms
`db44eaf`+dirty	1238.49 ms	1236.56 ms	-1.93 ms
`2ec71da`+dirty	1230.29 ms	1239.50 ms	9.21 ms
`e2b64fe`+dirty	1285.78 ms	1297.56 ms	11.78 ms
`8ab11b6`+dirty	1222.91 ms	1216.08 ms	-6.83 ms
`1c65324`+dirty	1239.71 ms	1239.86 ms	0.15 ms
`a0b0298`+dirty	1227.71 ms	1234.12 ms	6.41 ms
`83f6f6c`+dirty	1232.02 ms	1229.15 ms	-2.87 ms

App size

Revision	Plain	With Sentry	Diff
`8bda0cc`+dirty	3.19 MiB	4.26 MiB	1.08 MiB
`80b2ce3`+dirty	2.92 MiB	3.40 MiB	492.75 KiB
`31fcca2`+dirty	2.92 MiB	3.46 MiB	557.31 KiB
`db44eaf`+dirty	2.92 MiB	3.66 MiB	761.15 KiB
`2ec71da`+dirty	2.92 MiB	3.69 MiB	791.06 KiB
`e2b64fe`+dirty	2.92 MiB	3.41 MiB	499.97 KiB
`8ab11b6`+dirty	2.92 MiB	3.67 MiB	772.38 KiB
`1c65324`+dirty	2.92 MiB	3.61 MiB	705.56 KiB
`a0b0298`+dirty	3.19 MiB	4.32 MiB	1.13 MiB
`83f6f6c`+dirty	2.92 MiB	3.67 MiB	772.37 KiB

lucas-zimerman

Nice quick fix, LGTM!

lucas-zimerman

We should Fix the lint of RNSentryBreadcrumb, after that we can merge it!

packages/core/ios/RNSentryBreadcrumb.m

antonis

LGTM 🚀
Thank you for the added test 🙇

krystofwoldrich · 2025-03-06T17:22:45Z

Thank you. I've fixed the lint.

github-actions · 2025-03-06T17:53:53Z

Android (new) Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	339.17 ms	349.78 ms	10.60 ms
Size	7.15 MiB	8.39 MiB	1.23 MiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
`5571a20`+dirty	359.52 ms	389.80 ms	30.28 ms
`c71ea72`+dirty	410.57 ms	472.63 ms	62.06 ms
`79976dd`+dirty	373.25 ms	404.64 ms	31.39 ms
`686b3bc`+dirty	363.48 ms	356.17 ms	-7.31 ms
`488c9c5`+dirty	448.98 ms	531.62 ms	82.64 ms
`30189be`+dirty	362.02 ms	386.80 ms	24.78 ms
`b95b8af`+dirty	392.94 ms	428.00 ms	35.06 ms
`fc150fe`+dirty	409.55 ms	407.37 ms	-2.18 ms
`e73d82f`+dirty	377.67 ms	407.06 ms	29.39 ms
`c314a21`+dirty	419.41 ms	426.02 ms	6.61 ms

App size

Revision	Plain	With Sentry	Diff
`5571a20`+dirty	7.15 MiB	8.20 MiB	1.05 MiB
`c71ea72`+dirty	7.15 MiB	8.38 MiB	1.23 MiB
`79976dd`+dirty	7.15 MiB	8.38 MiB	1.23 MiB
`686b3bc`+dirty	7.15 MiB	8.38 MiB	1.23 MiB
`488c9c5`+dirty	7.15 MiB	8.38 MiB	1.23 MiB
`30189be`+dirty	7.15 MiB	8.38 MiB	1.23 MiB
`b95b8af`+dirty	7.15 MiB	8.38 MiB	1.23 MiB
`fc150fe`+dirty	7.15 MiB	8.38 MiB	1.23 MiB
`e73d82f`+dirty	7.15 MiB	8.34 MiB	1.19 MiB
`c314a21`+dirty	7.15 MiB	8.39 MiB	1.23 MiB

lucas-zimerman

LGTM!

fix(breadcrumb-ios): Handle non-string category in getCurrentScreen

c24b03e

krystofwoldrich requested review from lucas-zimerman and antonis as code owners March 5, 2025 16:45

lucas-zimerman approved these changes Mar 5, 2025

View reviewed changes

lucas-zimerman requested changes Mar 5, 2025

View reviewed changes

krystofwoldrich mentioned this pull request Mar 5, 2025

[__NSCFBoolean isEqualToString:]: unrecognized selector sent to instance #4627

Closed

antonis reviewed Mar 6, 2025

View reviewed changes

packages/core/ios/RNSentryBreadcrumb.m Outdated Show resolved Hide resolved

antonis approved these changes Mar 6, 2025

View reviewed changes

fix format

5cb08e8

krystofwoldrich enabled auto-merge (squash) March 6, 2025 17:21

krystofwoldrich requested a review from lucas-zimerman March 6, 2025 17:22

lucas-zimerman approved these changes Mar 7, 2025

View reviewed changes

krystofwoldrich merged commit e2aa97e into main Mar 7, 2025
70 checks passed

krystofwoldrich deleted the kw/gh-4627 branch March 7, 2025 01:52

Uh oh!

fix(breadcrumb-ios): Handle non-string category in getCurrentScreen #4629

fix(breadcrumb-ios): Handle non-string category in getCurrentScreen #4629

Uh oh!

Conversation

krystofwoldrich commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📢 Type of change

📜 Description

💚 How did you test it?

📝 Checklist

Uh oh!

github-actions bot commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Android (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (legacy) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

github-actions bot commented Mar 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

iOS (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

lucas-zimerman left a comment

Choose a reason for hiding this comment

Uh oh!

lucas-zimerman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

antonis left a comment

Choose a reason for hiding this comment

Uh oh!

krystofwoldrich commented Mar 6, 2025

Uh oh!

github-actions bot commented Mar 6, 2025

Android (new) Performance metrics 🚀

Baseline results on branch: main

Startup times

App size

Uh oh!

lucas-zimerman left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

krystofwoldrich commented Mar 5, 2025 •

edited

Loading

github-actions bot commented Mar 5, 2025 •

edited

Loading

github-actions bot commented Mar 5, 2025 •

edited

Loading

github-actions bot commented Mar 5, 2025 •

edited

Loading