Skip to content

chore(deps): update Cocoa SDK to v8.50.2 #4830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 15, 2025
Merged

Conversation

github-actions[bot]
Copy link
Contributor

Bumps scripts/update-cocoa.sh from 8.50.1 to 8.50.2.

Auto-generated by a dependency updater.

Changelog

8.50.2

Fixes

  • Improved time-to-display tracker to not crash when using view life cycle methods incorrectly (#5048)
  • Enable view renderer V2 by default in session replay and preview redact options when using initializer with default values (#5210)

@github-actions github-actions bot requested a review from krystofwoldrich as a code owner May 15, 2025 03:20
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label May 15, 2025
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label May 15, 2025
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-cocoa.sh branch from b79ade4 to 7082fe2 Compare May 15, 2025 03:20
Copy link
Contributor Author

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 429.64 ms 466.56 ms 36.92 ms
Size 17.75 MiB 20.13 MiB 2.38 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d997097 470.23 ms 475.46 ms 5.23 ms
87d396c 463.52 ms 500.31 ms 36.79 ms
0c98663 437.75 ms 420.70 ms -17.05 ms
4a6664f 548.79 ms 585.00 ms 36.21 ms
0ebca77 414.93 ms 444.49 ms 29.56 ms
15c80ab+dirty 336.27 ms 350.58 ms 14.31 ms
ac41368 451.47 ms 453.67 ms 2.20 ms
d16beca 448.87 ms 447.20 ms -1.67 ms
e1e6bc7 479.96 ms 482.58 ms 2.62 ms
31fcca2 391.22 ms 414.78 ms 23.56 ms

App size

Revision Plain With Sentry Diff
d997097 17.75 MiB 20.11 MiB 2.36 MiB
87d396c 17.75 MiB 20.13 MiB 2.38 MiB
0c98663 17.75 MiB 20.12 MiB 2.37 MiB
4a6664f 17.73 MiB 19.94 MiB 2.21 MiB
0ebca77 17.73 MiB 19.95 MiB 2.21 MiB
15c80ab+dirty 17.73 MiB 20.04 MiB 2.31 MiB
ac41368 17.73 MiB 20.11 MiB 2.38 MiB
d16beca 17.74 MiB 20.10 MiB 2.36 MiB
e1e6bc7 17.75 MiB 20.13 MiB 2.38 MiB
31fcca2 17.73 MiB 19.90 MiB 2.17 MiB

Previous results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision Plain With Sentry Diff
7140a40 664.39 ms 656.44 ms -7.95 ms
09a2115 359.96 ms 385.57 ms 25.61 ms
12e4be5 433.46 ms 417.33 ms -16.13 ms
9c4a204 439.59 ms 440.02 ms 0.43 ms
1dfac94 420.94 ms 408.17 ms -12.77 ms
e4aeaad 438.94 ms 457.71 ms 18.77 ms
6492e76 424.30 ms 414.10 ms -10.20 ms
a9355d1 488.72 ms 557.00 ms 68.28 ms
438739d 442.02 ms 457.96 ms 15.94 ms
77364bc 437.12 ms 434.90 ms -2.22 ms

App size

Revision Plain With Sentry Diff
7140a40 17.74 MiB 20.08 MiB 2.35 MiB
09a2115 17.75 MiB 20.12 MiB 2.37 MiB
12e4be5 17.75 MiB 20.12 MiB 2.37 MiB
9c4a204 17.74 MiB 20.08 MiB 2.34 MiB
1dfac94 17.75 MiB 20.13 MiB 2.38 MiB
e4aeaad 17.75 MiB 20.12 MiB 2.37 MiB
6492e76 17.75 MiB 20.13 MiB 2.38 MiB
a9355d1 17.74 MiB 20.10 MiB 2.36 MiB
438739d 17.75 MiB 20.11 MiB 2.37 MiB
77364bc 17.74 MiB 20.08 MiB 2.35 MiB

Copy link
Contributor Author

github-actions bot commented May 15, 2025

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 441.15 ms 455.02 ms 13.87 ms
Size 7.15 MiB 8.40 MiB 1.25 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
27ef4ee+dirty 296.71 ms 351.00 ms 54.29 ms
30189be+dirty 362.02 ms 386.80 ms 24.78 ms
9dabcce+dirty 359.66 ms 430.73 ms 71.08 ms
1332acb+dirty 385.00 ms 404.80 ms 19.80 ms
0677344+dirty 288.40 ms 391.44 ms 103.04 ms
0eacc98+dirty 393.31 ms 445.21 ms 51.90 ms
a5d86e1+dirty 380.86 ms 466.42 ms 85.56 ms
a38594f+dirty 393.83 ms 422.12 ms 28.29 ms
148f924+dirty 347.36 ms 389.13 ms 41.77 ms
d43a46b+dirty 417.65 ms 472.98 ms 55.33 ms

App size

Revision Plain With Sentry Diff
27ef4ee+dirty 7.15 MiB 8.08 MiB 959.49 KiB
30189be+dirty 7.15 MiB 8.38 MiB 1.23 MiB
9dabcce+dirty 7.15 MiB 8.37 MiB 1.22 MiB
1332acb+dirty 7.15 MiB 8.37 MiB 1.22 MiB
0677344+dirty 7.15 MiB 8.07 MiB 949.80 KiB
0eacc98+dirty 7.15 MiB 8.38 MiB 1.23 MiB
a5d86e1+dirty 7.15 MiB 8.35 MiB 1.20 MiB
a38594f+dirty 7.15 MiB 8.38 MiB 1.23 MiB
148f924+dirty 7.15 MiB 8.21 MiB 1.07 MiB
d43a46b+dirty 7.15 MiB 8.34 MiB 1.19 MiB

Previous results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision Plain With Sentry Diff
6858e4c+dirty 387.81 ms 376.10 ms -11.71 ms
a9355d1+dirty 374.27 ms 435.52 ms 61.25 ms
7140a40+dirty 419.33 ms 463.16 ms 43.83 ms
9c4a204+dirty 440.30 ms 484.81 ms 44.52 ms
e4aeaad+dirty 379.82 ms 379.89 ms 0.08 ms
6492e76+dirty 378.44 ms 380.92 ms 2.48 ms
62e1450+dirty 363.60 ms 401.13 ms 37.53 ms
438739d+dirty 394.50 ms 432.00 ms 37.50 ms
77364bc+dirty 368.47 ms 411.62 ms 43.16 ms
12e4be5+dirty 434.66 ms 447.90 ms 13.24 ms

App size

Revision Plain With Sentry Diff
6858e4c+dirty 7.15 MiB 8.39 MiB 1.23 MiB
a9355d1+dirty 7.15 MiB 8.38 MiB 1.23 MiB
7140a40+dirty 7.15 MiB 8.36 MiB 1.21 MiB
9c4a204+dirty 7.15 MiB 8.35 MiB 1.20 MiB
e4aeaad+dirty 7.15 MiB 8.39 MiB 1.23 MiB
6492e76+dirty 7.15 MiB 8.40 MiB 1.25 MiB
62e1450+dirty 7.15 MiB 8.36 MiB 1.21 MiB
438739d+dirty 7.15 MiB 8.38 MiB 1.23 MiB
77364bc+dirty 7.15 MiB 8.36 MiB 1.21 MiB
12e4be5+dirty 7.15 MiB 8.39 MiB 1.23 MiB

Copy link
Contributor Author

github-actions bot commented May 15, 2025

iOS (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1224.90 ms 1227.63 ms 2.73 ms
Size 3.19 MiB 4.37 MiB 1.18 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
b8ff156+dirty 1238.92 ms 1239.57 ms 0.66 ms
d8e8c67+dirty 1235.58 ms 1233.44 ms -2.15 ms
9c48b2c+dirty 1253.39 ms 1256.30 ms 2.91 ms
abb7058+dirty 1260.28 ms 1266.56 ms 6.28 ms
3853f43+dirty 1271.74 ms 1278.04 ms 6.30 ms
d197b5c+dirty 1234.80 ms 1249.20 ms 14.40 ms
c10f417+dirty 1218.61 ms 1225.41 ms 6.80 ms
b7eb05d+dirty 1234.69 ms 1242.52 ms 7.83 ms
776f0b5+dirty 1227.16 ms 1225.45 ms -1.71 ms
1d86dd6+dirty 1289.25 ms 1293.36 ms 4.11 ms

App size

Revision Plain With Sentry Diff
b8ff156+dirty 2.92 MiB 3.67 MiB 772.38 KiB
d8e8c67+dirty 2.92 MiB 3.69 MiB 790.53 KiB
9c48b2c+dirty 2.92 MiB 3.41 MiB 499.97 KiB
abb7058+dirty 2.92 MiB 3.43 MiB 524.53 KiB
3853f43+dirty 2.92 MiB 3.41 MiB 503.54 KiB
d197b5c+dirty 2.92 MiB 3.37 MiB 464.41 KiB
c10f417+dirty 3.19 MiB 4.36 MiB 1.17 MiB
b7eb05d+dirty 3.19 MiB 4.32 MiB 1.13 MiB
776f0b5+dirty 3.19 MiB 4.33 MiB 1.14 MiB
1d86dd6+dirty 2.92 MiB 3.44 MiB 538.27 KiB

Previous results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision Plain With Sentry Diff
62e1450+dirty 1231.73 ms 1234.63 ms 2.90 ms
60da2b3+dirty 1230.44 ms 1232.47 ms 2.03 ms
6492e76+dirty 1226.37 ms 1226.78 ms 0.41 ms
9c4a204+dirty 1250.62 ms 1244.24 ms -6.38 ms
438739d+dirty 1228.18 ms 1226.46 ms -1.73 ms
1dfac94+dirty 1230.76 ms 1231.53 ms 0.78 ms
09a2115+dirty 1232.63 ms 1244.80 ms 12.17 ms
3620199+dirty 1247.39 ms 1245.02 ms -2.37 ms
a9355d1+dirty 1231.51 ms 1239.04 ms 7.53 ms
e4aeaad+dirty 1212.94 ms 1216.24 ms 3.30 ms

App size

Revision Plain With Sentry Diff
62e1450+dirty 2.92 MiB 3.66 MiB 760.67 KiB
60da2b3+dirty 3.19 MiB 4.31 MiB 1.12 MiB
6492e76+dirty 3.19 MiB 4.34 MiB 1.16 MiB
9c4a204+dirty 2.92 MiB 3.64 MiB 741.21 KiB
438739d+dirty 3.19 MiB 4.27 MiB 1.08 MiB
1dfac94+dirty 3.19 MiB 4.35 MiB 1.16 MiB
09a2115+dirty 3.19 MiB 4.32 MiB 1.13 MiB
3620199+dirty 3.19 MiB 4.35 MiB 1.16 MiB
a9355d1+dirty 2.92 MiB 3.69 MiB 790.55 KiB
e4aeaad+dirty 3.19 MiB 4.33 MiB 1.14 MiB

Copy link
Contributor Author

github-actions bot commented May 15, 2025

iOS (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1218.54 ms 1219.75 ms 1.21 ms
Size 2.63 MiB 3.80 MiB 1.17 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
b8ff156+dirty 1236.51 ms 1234.53 ms -1.98 ms
d8e8c67+dirty 1222.57 ms 1226.22 ms 3.65 ms
9c48b2c+dirty 1246.96 ms 1255.73 ms 8.77 ms
abb7058+dirty 1255.42 ms 1268.86 ms 13.44 ms
3853f43+dirty 1221.82 ms 1242.64 ms 20.82 ms
d197b5c+dirty 1217.61 ms 1242.66 ms 25.05 ms
c10f417+dirty 1211.27 ms 1212.85 ms 1.59 ms
b7eb05d+dirty 1215.71 ms 1221.38 ms 5.67 ms
776f0b5+dirty 1221.61 ms 1222.02 ms 0.41 ms
1d86dd6+dirty 1249.71 ms 1279.16 ms 29.45 ms

App size

Revision Plain With Sentry Diff
b8ff156+dirty 2.36 MiB 3.11 MiB 759.80 KiB
d8e8c67+dirty 2.36 MiB 3.12 MiB 779.40 KiB
9c48b2c+dirty 2.36 MiB 2.85 MiB 495.77 KiB
abb7058+dirty 2.36 MiB 2.87 MiB 520.42 KiB
3853f43+dirty 2.36 MiB 2.85 MiB 499.81 KiB
d197b5c+dirty 2.36 MiB 2.82 MiB 462.86 KiB
c10f417+dirty 2.63 MiB 3.79 MiB 1.16 MiB
b7eb05d+dirty 2.63 MiB 3.75 MiB 1.12 MiB
776f0b5+dirty 2.63 MiB 3.76 MiB 1.13 MiB
1d86dd6+dirty 2.36 MiB 2.89 MiB 535.43 KiB

Previous results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision Plain With Sentry Diff
62e1450+dirty 1219.45 ms 1236.33 ms 16.88 ms
60da2b3+dirty 1212.45 ms 1222.61 ms 10.16 ms
6492e76+dirty 1218.27 ms 1221.04 ms 2.78 ms
9c4a204+dirty 1231.46 ms 1239.71 ms 8.25 ms
438739d+dirty 1213.33 ms 1216.20 ms 2.88 ms
1dfac94+dirty 1224.62 ms 1217.02 ms -7.60 ms
09a2115+dirty 1233.45 ms 1229.50 ms -3.95 ms
3620199+dirty 1214.30 ms 1212.92 ms -1.38 ms
a9355d1+dirty 1236.78 ms 1245.20 ms 8.43 ms
e4aeaad+dirty 1241.18 ms 1235.51 ms -5.67 ms

App size

Revision Plain With Sentry Diff
62e1450+dirty 2.36 MiB 3.10 MiB 755.61 KiB
60da2b3+dirty 2.63 MiB 3.74 MiB 1.11 MiB
6492e76+dirty 2.63 MiB 3.78 MiB 1.14 MiB
9c4a204+dirty 2.36 MiB 3.08 MiB 735.56 KiB
438739d+dirty 2.63 MiB 3.70 MiB 1.07 MiB
1dfac94+dirty 2.63 MiB 3.78 MiB 1.14 MiB
09a2115+dirty 2.63 MiB 3.75 MiB 1.12 MiB
3620199+dirty 2.63 MiB 3.78 MiB 1.15 MiB
a9355d1+dirty 2.36 MiB 3.12 MiB 779.40 KiB
e4aeaad+dirty 2.63 MiB 3.76 MiB 1.13 MiB

@@ -177,7 +177,7 @@ final class RNSentryReplayOptions: XCTestCase {

let actualOptions = try! Options(dict: optionsDict as! [String: Any])

XCTAssertFalse(actualOptions.sessionReplay.enableExperimentalViewRenderer)
XCTAssertTrue(actualOptions.sessionReplay.enableExperimentalViewRenderer)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to match new default value getsentry/sentry-cocoa#5210

Copy link
Collaborator

@antonis antonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉
This would unblock #4815

@antonis antonis merged commit 568f711 into main May 15, 2025
71 of 73 checks passed
@antonis antonis deleted the deps/scripts/update-cocoa.sh branch May 15, 2025 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants