V7: Uppercase boolean flags #4965
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| fb47c4a | 435.33 ms | 434.94 ms | -0.40 ms |
| 472960b | 418.84 ms | 405.38 ms | -13.46 ms |
| 7eff2d7 | 420.64 ms | 401.86 ms | -18.78 ms |
| 3c99746 | 399.51 ms | 429.09 ms | 29.58 ms |
| f870f2d | 444.67 ms | 449.62 ms | 4.95 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| fb47c4a | 17.75 MiB | 19.60 MiB | 1.85 MiB |
| 472960b | 17.75 MiB | 19.58 MiB | 1.83 MiB |
| 7eff2d7 | 17.75 MiB | 19.60 MiB | 1.85 MiB |
| 3c99746 | 17.75 MiB | 19.58 MiB | 1.83 MiB |
| f870f2d | 17.75 MiB | 19.58 MiB | 1.83 MiB |
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f870f2d+dirty | 398.49 ms | 434.24 ms | 35.75 ms |
| fb47c4a+dirty | 408.58 ms | 407.17 ms | -1.41 ms |
| 472960b+dirty | 394.39 ms | 376.18 ms | -18.20 ms |
| 7eff2d7+dirty | 393.13 ms | 426.77 ms | 33.65 ms |
| 3c99746+dirty | 400.65 ms | 399.59 ms | -1.06 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f870f2d+dirty | 7.15 MiB | 8.34 MiB | 1.18 MiB |
| fb47c4a+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
| 472960b+dirty | 7.15 MiB | 8.34 MiB | 1.18 MiB |
| 7eff2d7+dirty | 7.15 MiB | 8.35 MiB | 1.20 MiB |
| 3c99746+dirty | 7.15 MiB | 8.34 MiB | 1.18 MiB |
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f870f2d+dirty | 1227.18 ms | 1232.30 ms | 5.12 ms |
| 472960b+dirty | 1213.96 ms | 1222.58 ms | 8.62 ms |
| fb47c4a+dirty | 1231.00 ms | 1231.33 ms | 0.33 ms |
| 7eff2d7+dirty | 1225.34 ms | 1234.53 ms | 9.19 ms |
| 3c99746+dirty | 1215.12 ms | 1222.31 ms | 7.18 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f870f2d+dirty | 2.63 MiB | 3.79 MiB | 1.15 MiB |
| 472960b+dirty | 2.63 MiB | 3.79 MiB | 1.15 MiB |
| fb47c4a+dirty | 2.63 MiB | 3.80 MiB | 1.17 MiB |
| 7eff2d7+dirty | 2.63 MiB | 3.79 MiB | 1.16 MiB |
| 3c99746+dirty | 2.63 MiB | 3.78 MiB | 1.15 MiB |
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f870f2d+dirty | 1230.08 ms | 1238.88 ms | 8.80 ms |
| 472960b+dirty | 1243.67 ms | 1233.57 ms | -10.11 ms |
| fb47c4a+dirty | 1243.40 ms | 1245.86 ms | 2.46 ms |
| 7eff2d7+dirty | 1224.84 ms | 1227.94 ms | 3.10 ms |
| 3c99746+dirty | 1227.65 ms | 1228.81 ms | 1.16 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| f870f2d+dirty | 3.19 MiB | 4.36 MiB | 1.17 MiB |
| 472960b+dirty | 3.19 MiB | 4.36 MiB | 1.17 MiB |
| fb47c4a+dirty | 3.19 MiB | 4.37 MiB | 1.18 MiB |
| 7eff2d7+dirty | 3.19 MiB | 4.36 MiB | 1.17 MiB |
| 3c99746+dirty | 3.19 MiB | 4.35 MiB | 1.16 MiB |
lucas-zimerman
changed the title
antonis
reviewed
Jul 7, 2025
antonis
reviewed
Jul 7, 2025
There was a problem hiding this comment.
Awesome work @lucas-zimerman 🚀
The implementation LGTM. Thank you for the added tests and updating the sample app.
Just added a note on a typo.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📢 Type of change
📜 Description
This PR formats boolean flags on a capitalized format, also fixed the issue if users tries to set a a symbol as a tag.
💡 Motivation and Context
Fixes #4744
Why an integration?
This way it's easy to rollback to the original state if needed, and also it unifies the way we apply the changes between web and mobile.
💚 How did you test it?
Unit tests and local
iOS:
https://sentry-sdks.sentry.io/issues/6722231659/events/24d96d2c84e746ea86ce32776590a939/?project=5428561
https://sentry-sdks.sentry.io/issues/6722231616/events/946bfc7a105f4c5f938a311691520859/?project=5428561
After set/unset tags
https://sentry-sdks.sentry.io/issues/5005275690/events/337444288da644129839858236149d4e/?project=5428561
Android
https://sentry-sdks.sentry.io/issues/6722231616/events/e0766bde09714075871bb8b860c7f054/?project=5428561
https://sentry-sdks.sentry.io/issues/6722231659/events/6a0a476505244ceaaf38732d372759c2/?project=5428561
After set/unset tags
https://sentry-sdks.sentry.io/issues/5005275690/events/f00552ca3f5a441c8a10ebb8cb3a033a/?project=5428561
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps
Test RN Web