Skip to content

Structured Logging Improvements #2389

@bitsandfoxes

Description

@bitsandfoxes

Description

I've put the structured log capture into UnityLogHandlerIntegration and not the UnityApplicationLoggingIntegration because there we have access to the pre-formatted template and args that can directly be passed into the logger without having to format the message ourselves.

Turns out, the .NET SDK calls string.Format in any case anyway, see DefaultStructuredLogger.

Additionally, the origin is missing.

The way forward I see is to move the capture into the UnityApplicationLoggingIntegration and use the already formatted string provided to construct the SentryLog object and pass that into the logger to be captured.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    Status

    No status

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions