Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/sentry/deletions/defaults/alert_rule_trigger.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,11 @@
class AlertRuleTriggerDeletionTask(ModelDeletionTask[AlertRuleTrigger]):
def get_child_relations(self, instance: AlertRuleTrigger) -> list[BaseRelation]:
from sentry.incidents.models.alert_rule import AlertRuleTriggerAction
from sentry.incidents.models.incident import IncidentTrigger
from sentry.workflow_engine.models import DataConditionAlertRuleTrigger

return [
ModelRelation(AlertRuleTriggerAction, {"alert_rule_trigger_id": instance.id}),
ModelRelation(IncidentTrigger, {"alert_rule_trigger_id": instance.id}),
ModelRelation(DataConditionAlertRuleTrigger, {"alert_rule_trigger_id": instance.id}),
]
8 changes: 8 additions & 0 deletions tests/sentry/deletions/test_alert_rule_trigger.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
from sentry.deletions.tasks.scheduled import run_scheduled_deletions
from sentry.incidents.models.alert_rule import AlertRule, AlertRuleTrigger, AlertRuleTriggerAction
from sentry.incidents.models.incident import IncidentTrigger, TriggerStatus
from sentry.testutils.hybrid_cloud import HybridCloudTestMixin
from sentry.workflow_engine.models import DataConditionAlertRuleTrigger
from tests.sentry.workflow_engine.test_base import BaseWorkflowTest
Expand All @@ -16,6 +17,12 @@ def test_simple(self) -> None:
DataConditionAlertRuleTrigger.objects.create(
data_condition=data_condition, alert_rule_trigger_id=alert_rule_trigger.id
)
incident = self.create_incident(alert_rule=alert_rule)
incident_trigger = self.create_incident_trigger(
incident=incident,
alert_rule_trigger=alert_rule_trigger,
status=TriggerStatus.ACTIVE.value,
)

self.ScheduledDeletion.schedule(instance=alert_rule_trigger, days=0)

Expand All @@ -25,6 +32,7 @@ def test_simple(self) -> None:
assert AlertRule.objects.filter(id=alert_rule.id).exists()
assert not AlertRuleTrigger.objects.filter(id=alert_rule_trigger.id).exists()
assert not AlertRuleTriggerAction.objects.filter(id=alert_rule_trigger_action.id).exists()
assert not IncidentTrigger.objects.filter(id=incident_trigger.id).exists()
assert not DataConditionAlertRuleTrigger.objects.filter(
alert_rule_trigger_id=alert_rule_trigger.id
).exists()
Loading