fix(replay) - fix use fetch parallel pages #101462
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
jerryzhou196
changed the title
billyvg
reviewed
Oct 14, 2025
ryan953
approved these changes
Oct 14, 2025
ryan953
approved these changes
Oct 14, 2025
jerryzhou196
changed the title
jerryzhou196
added a commit
that referenced
this pull request
Oct 22, 2025
1. Makes the refresh button only reload what's necessary instead of a full-page refresh. 2. Refactors `usePollReplayRecord` to return the `replayRecord` instead of just `count_segments` 3. Removes `useIsLive` hook and determines LIVE by checking if polled Date.now() < `replayRecord.finished_at()` + 5 minutes 4. Adds tests for `usePollReplayRecord` and the refresh button before|after --|-- | requires #101462 --------- Co-authored-by: Cursor Agent <[email protected]> Co-authored-by: ryan.albrecht <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building the background refresh, Billy and I encountered some bugs with useFetchParallelPages.
a. It doesn't refetch with a different hits value:
useFetchParallelPages({hits = 12, perPage = 100}), then we would have pages=1useFetchParallelPages({hits = 15, perPage = 100}), then we would still have pages=1 and the old version ofcursors. The useEffect later wouldn't runfetch()on re-render when it should.