feat(tracemetrics): Update UX to separate query builder from charts #101465
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
nsdeschenes
approved these changes
Oct 15, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #101465 +/- ##
========================================
Coverage 81.02% 81.02%
========================================
Files 8701 8701
Lines 386016 386004 -12
Branches 24409 24407 -2
========================================
Hits 312770 312770
+ Misses 72895 72883 -12
Partials 351 351 |
narsaynorath
deleted the
narsaynorath/logs-415-separate-query-builder-from-chart
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separate the query toolbar from the charts by iterating over the
metricQueriestwice and rendering the selectors in one block and the charts in another block. Also adds anidvalue that is used to label the query and the chart.Screen.Recording.2025-10-14.at.4.01.56.PM.mov