feat(aci): Rewire insights crons/uptime links to go to Monitors #103129
+64
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
scttcper
approved these changes
Nov 11, 2025
Comment on lines
+10
to
+13
| const [wasRedirectedFromInsights, setWasRedirectedFromInsights] = useQueryState( | ||
| 'insightsRedirect', | ||
| parseAsBoolean.withOptions({history: 'replace'}).withDefault(false) | ||
| ); |
Member
|
Let's not merge this yet, since it means it's difficult to see the old UI. Or maybe @malwilley we could create a new feature flag for the LA/EA/GA experience? Where this and Alerts etc are hidden away. if we do that we could also track some metrics for people with that flag who still somehow end up on the alert pages. |
Member
Author
|
@evanpurkhiser do you mean that it will be difficult for us internally to see the old UI? We could add an |
ameliahsu
reviewed
Nov 13, 2025
| ? starredProjects.slice(0, 8) | ||
| : nonStarredProjects.filter(project => project.isMember).slice(0, 8); | ||
|
|
||
| const hasWorkflowEngineUi = organization.features.includes('workflow-engine-ui'); |
Member
There was a problem hiding this comment.
I've been adding a isStaff check here so that staff don't get redirected during testing
Member
Author
There was a problem hiding this comment.
Will add that then merge
…ve-links-to-insights-crons-uptime-pages
ameliahsu
added a commit
that referenced
this pull request
Nov 15, 2025
similar to #103129, redirects users with the `workflow-engine-ui` flag who click on Issues > Alerts to the All Monitors list with a banner <img width="1381" height="332" alt="Screenshot 2025-11-13 at 11 56 52 AM" src="https://github.com/user-attachments/assets/00194e9e-1f85-4f23-9858-3c54a4c9e09a" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes NEW-617, NEW-618
When the feature flag is on, insights crons/uptime links will direct to /monitors instead. When this happens, we'll show a banner that notifies the user about this change: