Skip to content

Conversation

@shellmayr
Copy link
Member

Closes #68416

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 10, 2024
@codecov
Copy link

codecov bot commented Apr 10, 2024

Bundle Report

Changes will increase total bundle size by 78.97kB ⬆️

Bundle name Size Change
sentry-webpack-bundle-array-push 26.29MB 78.97kB ⬆️

@shellmayr shellmayr assigned shellmayr and iambriccardo and unassigned shellmayr Apr 11, 2024
@iambriccardo iambriccardo marked this pull request as ready for review April 11, 2024 15:11
@iambriccardo iambriccardo requested a review from a team as a code owner April 11, 2024 15:11
@iambriccardo iambriccardo removed their assignment Apr 11, 2024
@iambriccardo iambriccardo self-requested a review April 11, 2024 15:12
@shellmayr shellmayr marked this pull request as draft April 11, 2024 15:16
@codecov
Copy link

codecov bot commented Apr 12, 2024

Codecov Report

Attention: Patch coverage is 93.93939% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 79.78%. Comparing base (14f190c) to head (a9e5192).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #68594      +/-   ##
==========================================
+ Coverage   79.68%   79.78%   +0.10%     
==========================================
  Files        6429     6420       -9     
  Lines      285249   284618     -631     
  Branches    49131    49038      -93     
==========================================
- Hits       227291   227086     -205     
+ Misses      57567    57177     -390     
+ Partials      391      355      -36     
Files Coverage Δ
src/sentry/sentry_metrics/querying/data/api.py 100.00% <100.00%> (ø)
...entry_metrics/querying/data/postprocessing/base.py 100.00% <100.00%> (ø)
...trics/querying/data/postprocessing/demodulation.py 100.00% <100.00%> (ø)
...y/sentry_metrics/querying/data/preparation/base.py 100.00% <100.00%> (ø)
...ry_metrics/querying/data/preparation/modulation.py 100.00% <100.00%> (ø)
...entry_metrics/querying/visitors/query_condition.py 77.61% <100.00%> (+14.19%) ⬆️
...c/sentry/sentry_metrics/querying/data/execution.py 94.20% <94.73%> (-0.06%) ⬇️
...s/querying/data/modulation/modulation_value_map.py 90.00% <90.00%> (ø)
...ntry_metrics/querying/data/modulation/modulator.py 88.37% <88.37%> (ø)
...ntry_metrics/querying/visitors/query_expression.py 89.12% <86.79%> (-0.20%) ⬇️

... and 353 files with indirect coverage changes

@shellmayr shellmayr changed the title Add visitor to replace project-filter by project-id-filter in query Enable queries using project slug as filter and groupby in Metrics API Apr 17, 2024
@shellmayr
Copy link
Member Author

Closed - superseded by #69111

@github-actions github-actions bot locked and limited conversation to collaborators May 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement project <-> project_id transformation in the metrics API

3 participants