feat(replay): Show Seen-by list of users on Replay Details

[ryan953]

Avatar list is kinda weird, it sticks out to the left:

Relates to https://github.com/getsentry/team-replay/issues/19
Relates to #64924

Depends on #68990

[codecov]

Bundle Report

Changes will increase total bundle size by 714 bytes ⬆️

Bundle name	Size	Change
sentry-webpack-bundle-array-push	26.3MB	714 bytes ⬆️

[michellewzhang]

should we check for isErroror isLoading in the useApiQuery call or is that not needed here?

[ryan953]

should we check for isErroror isLoading in the useApiQuery call or is that not needed here?

I didn't deal with isError because I didn't really know what to tell the user :(. We could offer a retry button, but it's a small part of the page so idk if that's just distracting or calling too much attention to it. Open to ideas though.

As for loading, it'll just render once we have data. So we don't need to check the other field.

[michellewzhang]

I didn't deal with isError because I didn't really know what to tell the user :(. We could offer a retry button, but it's a small part of the page so idk if that's just distracting or calling too much attention to it. Open to ideas though.

that's a good point. placeholder makes sense as a subtle default here, which i think you've already done 👍

[billyvg]

should we check for isErroror isLoading in the useApiQuery call or is that not needed here?

I didn't deal with isError because I didn't really know what to tell the user :(. We could offer a retry button, but it's a small part of the page so idk if that's just distracting or calling too much attention to it. Open to ideas though.

As for loading, it'll just render once we have data. So we don't need to check the other field.

We have a "mini" error boundary component I think, but I agree that this is a small part of the page and not a deal breaker if it's broken (as long as its logged to Sentry)

[ryan953]

We have a "mini" error boundary component I think, but I agree that this is a small part of the page and not a deal breaker if it's broken (as long as its logged to Sentry)

Added logging. The mini variant is still a bit big. But we can iterate on it too depending on how often it happens.

[ryan953]

should we check for isErroror isLoading in the useApiQuery call or is that not needed here?

@michellewzhang you were right about this. I think the tests in CI are trying to assert that the placeholder goes away, but with the setup i had before they could be there forever. Now it's checking for isLoaded, and if it's loaded we'll remove the placeholder for sure, and render 0 or more avatars.