fix(replay): Fixes type error if same param is in url

[c298lee]

There are edge cases where getParamValue() will have a return type of string[] due to location.query[key] which caused the type error. This edge case happens when the same key is in the URL more than once, which could happen if someone pastes the url twice.
We are expecting a string from this function, so if location.query[key] is an array, we will just return the first value in the array.

Fixes JAVASCRIPT-2SFK

[codecov]

Bundle Report

Changes will decrease total bundle size by 33.53kB ⬇️

Bundle name	Size	Change
sentry-webpack-bundle-array-push	26.27MB	33.53kB ⬇️

[billyvg]

This is valid behavior, we shouldn't force this in the hook, but it should be handled in the hook consumers

[c298lee]

This is valid behavior, we shouldn't force this in the hook, but it should be handled in the hook consumers

We currently have the return type of the hook set to string instead of string | string[] so currently the hook consumers assume that there will only be unique param keys. I decided to put it in the hook since this would require more changes if done in the hook consumer, but I can change it to the consumer instead

[ryan953]

Suggested change

	? location.query[key]?.[0] ?? defaultValue
	? location.query[key]?.at(0) ?? defaultValue

[ryan953]

because of noUncheckedIndexedAccess

[billyvg]

This is valid behavior, we shouldn't force this in the hook, but it should be handled in the hook consumers

We currently have the return type of the hook set to string instead of string | string[] so currently the hook consumers assume that there will only be unique param keys. I decided to put it in the hook since this would require more changes if done in the hook consumer, but I can change it to the consumer instead

OK, let's keep it as-is in that case since they are already expecting a singular value (the function name reinforces this). If they need an array, they can later add on a different getter.

Let's add a comment here about why we're doing this and why first value over last (even if it's we are arbitrarily picking one, it's plenty helpful), and also a test.

[billyvg]

idk what's easier to read

      return (
        Array.isArray(location.query[key])
          ? location.query[key]?.at(0)
          : location.query[key]
        ) ?? defaultValue;