ref(search) case insensitive grammar #69146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Evan Purkhiser <[email protected]>
github-actions
bot
added
the
Scope: Backend
wedamija
approved these changes
Apr 17, 2024
Member
wedamija
left a comment
wedamija
left a comment
There was a problem hiding this comment.
lgtm, should be equivalent. I have some vague memory of changes like this changing the structure that parsimonious uses, but if it breaks anything it should show up in tests
Base automatically changed from
jb/search/case-sensitive-size-frontend
to
master
April 17, 2024 21:30
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same love for the backend