ref(app-starts): Generalize screen table component #69839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This component can be reused in the other mobile modules, generalize the screen table so we can pass in custom header name maps and body cell renderers.
github-actions
bot
added
the
Scope: Frontend
narsaynorath
requested review from
a team,
JonasBa,
doralchan,
gggritso,
indragiek,
jjbayer,
k-fish and
wmak
…-for-rendering-data
Bundle ReportChanges will increase total bundle size by 18.28kB ⬆️
|
Contributor
edwardgou-sentry
left a comment
edwardgou-sentry
left a comment
There was a problem hiding this comment.
lgtm, just a couple nits
static/app/views/performance/mobile/appStarts/screens/screensTable.tsx
Outdated
Show resolved
Hide resolved
static/app/views/performance/mobile/components/screensTable.tsx
Outdated
Show resolved
Hide resolved
edwardgou-sentry
approved these changes
Apr 29, 2024
narsaynorath
deleted the
nar/ref/generalize-screens-table-component-for-rendering-data
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This component can be reused in the other mobile modules, generalize the screen table so we can pass in custom header name maps and body cell renderers.