Skip to content

Conversation

@evanpurkhiser
Copy link
Member

@evanpurkhiser evanpurkhiser commented Apr 29, 2024

This is primarily a typing adjustment. Since we're not using
FilterStep we're never going to actually get a FilteredPayload.

@evanpurkhiser evanpurkhiser requested a review from a team as a code owner April 29, 2024 18:15
@evanpurkhiser evanpurkhiser changed the title reF(py): Update monitor_consumer to handle FilteredPayload ref(py): Update monitor_consumer to handle FilteredPayload Apr 29, 2024
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 29, 2024
This is primarily a typing adjustment. Since we're not actually using
FilterStep we're never going to actualy get a FilteredPayload.
@evanpurkhiser evanpurkhiser force-pushed the evanpurkhiser/ref-py-update-monitor-consumer-to-handle-filteredpayload branch from 46bbb94 to 532ebdb Compare April 29, 2024 18:34
@codecov
Copy link

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.84%. Comparing base (052229e) to head (532ebdb).
Report is 8 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #69904       +/-   ##
===========================================
+ Coverage   58.33%   79.84%   +21.50%     
===========================================
  Files        6478     6489       +11     
  Lines      288115   288559      +444     
  Branches    49632    49688       +56     
===========================================
+ Hits       168086   230409    +62323     
+ Misses     119626    57752    -61874     
+ Partials      403      398        -5     
Files Coverage Δ
src/sentry/monitors/consumers/monitor_consumer.py 88.92% <100.00%> (+69.33%) ⬆️

... and 1927 files with indirect coverage changes

@evanpurkhiser evanpurkhiser merged commit f9e6717 into master Apr 29, 2024
@evanpurkhiser evanpurkhiser deleted the evanpurkhiser/ref-py-update-monitor-consumer-to-handle-filteredpayload branch April 29, 2024 19:39
@evanpurkhiser evanpurkhiser self-assigned this May 6, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants