Skip to content

ref: fix BytesWarning in last_seen_updater #69909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 29, 2024
Merged

ref: fix BytesWarning in last_seen_updater #69909

merged 2 commits into from
Apr 29, 2024

Conversation

@asottile-sentry
Copy link
Contributor

@asottile-sentry asottile-sentry commented Apr 29, 2024

  1. I added the type annotation to the test such that mypy pointed out the mistake in the test data
  2. I adjusted the test data to match the required type
  3. I ran python3 -b -m pytest ... to surface the warning
  4. I fixed the warning

@asottile-sentry asottile-sentry requested a review from a team April 29, 2024 18:44
@asottile-sentry asottile-sentry requested a review from a team as a code owner April 29, 2024 18:44
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Apr 29, 2024
@asottile-sentry asottile-sentry enabled auto-merge (squash) April 29, 2024 19:15
@asottile-sentry asottile-sentry merged commit 2c13e60 into master Apr 29, 2024
@asottile-sentry asottile-sentry deleted the asottile-fix-bytes-warnings-last-seen-updater branch April 29, 2024 19:16
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@IanWoodard IanWoodard IanWoodard approved these changes

+1 more reviewer

@john-z-yang john-z-yang john-z-yang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@asottile-sentry @john-z-yang @IanWoodard