fix(grouping): Remove None from SimilarIssuesEmbeddingsResponse type
#69993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #69993 +/- ##
========================================
Coverage 79.83% 79.83%
========================================
Files 6495 6497 +2
Lines 288969 289126 +157
Branches 49765 49783 +18
========================================
+ Hits 230686 230824 +138
- Misses 57887 57906 +19
Partials 396 396
|
jangjodi
approved these changes
Apr 30, 2024
lobsterkatie
deleted the
kmclb-remove-None-from-SimilarIssuesEmbeddingsResponse-type
branch
lobsterkatie
added a commit
that referenced
this pull request
May 1, 2024
This is a handful of small fixes pulled out of a few upcoming PRs, in order to make them easier to review. Changes: - Switch from using inheritance and `total=False` to using `NotRequired` for optional properties of `SimilarIssuesEmbeddingsRequest`, so everything can be in one class. - Add exception types thrown by deserialization to the `try-except` block surrounding the parsing of seer response data, and add a log to track if/when things go wrong. Also simplify returning an empty result-set from the `except` block. - Simplify a few places where we were using `update` to add a single key-value pair to a dictionary. - Remove an unnecessary check for the existence of entries in the seer result-set. This should have been part of #69993, but it got missed. - Rename `response`/`responses` in `get_formatted_results` to `similar_issue_data`/`similar_issues_data` in preparation for changing some seer data datatypes. - Add a TODO to track the fact that we need to at some point let seer know when it's recommending groups which no longer exist. - Fix the data in a `get_similar_issues_embeddings` test to match the `SimilarIssuesEmbeddingsData` type. (It was given in terms of message and stacktrace similarity rather than distance.) - Add types to similar issues endpoint helpers. - Prepend `get_value_if_exists` with an underscore since it's an internal helper.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When seer doesn't find any near-enough neighbors, it sends back an empty list rather than
None, and when it sends back results, none of them are everNone. We therefore don't need theNonein the seer response typing.