Skip to content

feat(cache): add average transaction duration to sample sidebar #70445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 8, 2024
Merged

feat(cache): add average transaction duration to sample sidebar #70445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5b4a117
add avg transaction duration to samples
DominikB2014 May 7, 2024
1585e10
typing
DominikB2014 May 7, 2024
62f64e2
code review
DominikB2014 May 8, 2024
1513ba7
code review
DominikB2014 May 8, 2024
ba88910
Merge branch 'master' into DominikB2014/add-cache-transaction-duratio…
DominikB2014 May 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 24 additions & 1 deletion static/app/views/performance/cache/samplePanel/samplePanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,10 +25,12 @@ import {MetricReadout} from 'sentry/views/performance/metricReadout';
import * as ModuleLayout from 'sentry/views/performance/moduleLayout';
import DetailPanel from 'sentry/views/starfish/components/detailPanel';
import {getTimeSpentExplanation} from 'sentry/views/starfish/components/tableCells/timeSpentCell';
import {useSpanMetrics} from 'sentry/views/starfish/queries/useDiscover';
import {useMetrics, useSpanMetrics} from 'sentry/views/starfish/queries/useDiscover';
import {useIndexedSpans} from 'sentry/views/starfish/queries/useIndexedSpans';
import {useTransactions} from 'sentry/views/starfish/queries/useTransactions';
import {
MetricsFields,
type MetricsQueryFilters,
SpanFunction,
SpanIndexedField,
type SpanIndexedQueryFilters,
Expand Down Expand Up @@ -76,6 +78,15 @@ export function CacheSamplePanel() {
referrer: Referrer.SAMPLES_CACHE_METRICS_RIBBON,
});

const {data: transactionDurationData, isLoading: isTransactionDurationLoading} =
useMetrics({
search: MutableSearch.fromQueryObject({
transaction: query.transaction,
} satisfies MetricsQueryFilters),
fields: [`avg(${MetricsFields.TRANSACTION_DURATION})`],
enabled: isPanelOpen && Boolean(query.transaction),
});

const sampleFilters: SpanIndexedQueryFilters = {
...BASE_FILTERS,
transaction: query.transaction,
Expand Down Expand Up @@ -192,6 +203,18 @@ export function CacheSamplePanel() {
isLoading={areCacheTransactionMetricsFetching}
/>

<MetricReadout
align="left"
title={DataTitles[`avg(${MetricsFields.TRANSACTION_DURATION})`]}
value={
transactionDurationData?.[0]?.[
`avg(${MetricsFields.TRANSACTION_DURATION})`
]
}
unit={DurationUnit.MILLISECOND}
isLoading={isTransactionDurationLoading}
/>

<MetricReadout
align="left"
title={DataTitles.cacheMissRate}
Expand Down
2 changes: 2 additions & 0 deletions static/app/views/starfish/views/spans/types.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ export type DataKey =
| 'count'
| 'avg(http.response_content_length)'
| 'avg(http.decoded_response_content_length)'
| 'avg(transaction.duration)'
| 'avg(http.response_transfer_size)'
| 'bundleSize'
| 'unsuccessfulHTTPCodes'
Expand All @@ -44,6 +45,7 @@ export const DataTitles: Record<DataKey, string> = {
'avg(http.response_content_length)': t('Avg Encoded Size'),
'avg(http.decoded_response_content_length)': t('Avg Decoded Size'),
'avg(http.response_transfer_size)': t('Avg Transfer Size'),
'avg(transaction.duration)': t('Avg Txn Duration'),
'avg(cache.item_size)': t('Avg Value Size'),
unsuccessfulHTTPCodes: t('Response Codes (3XX, 4XX, 5XX)'),
httpCodeBreakdown: t('Response Code Breakdown'),
Expand Down