feat(performance): Adds error rate to queues module #70883
Conversation
github-actions
bot
added
the
Scope: Frontend
gggritso
left a comment
gggritso
left a comment
There was a problem hiding this comment.
All the 1 - are a huge bummer 😢 someone's going to trip over that for sure. If there's any chance of implementing that Discover-side on the backend, it's so worth it! Otherwise LGTM
| const destination = decodeScalar(query.destination); | ||
|
|
||
| const {data} = useQueuesMetricsQuery({destination}); | ||
| const errorRate = 1 - (data[0]?.['trace_status_rate(ok)'] ?? 0); |
There was a problem hiding this comment.
😅 there's no trace_status_rate(error) for you?
There was a problem hiding this comment.
Unfortunately the trace context status has a bunch of different error states:
https://develop.sentry.dev/sdk/event-payloads/contexts/#trace-context
ie cancelled, unknown, invalid_argument are all possible values and are all considered errors.
Right now trace_status_rate just applies a filter for the provided status
I can update this in discover as a follow up!
There was a problem hiding this comment.
Makes sense! Definitely worth it to define a helper for this in Discover regardless, if possible
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Updates the Queues module to now fully display error rate in the:
Also includes a minor fix to producer/consumer sample panel readouts not showing accurate span counts.