fix(similarity): allow single_org sentry users to not be superuser to call backfill #70917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
vartec
approved these changes
May 15, 2024
Comment on lines
22
to
24
| if not features.has("projects:similarity-embeddings-backfill", project) or ( | ||
| not is_active_superuser(request) and not settings.SENTRY_SINGLE_ORGANIZATION | ||
| ): |
Contributor
There was a problem hiding this comment.
As I understand it, you're allowed to go through if any of these conditions are true.
This would make it more obvious.
Suggested change
| if not features.has("projects:similarity-embeddings-backfill", project) or ( | |
| not is_active_superuser(request) and not settings.SENTRY_SINGLE_ORGANIZATION | |
| ): | |
| if not ( | |
| features.has("projects:similarity-embeddings-backfill", project) | |
| or is_active_superuser(request) | |
| or settings.SENTRY_SINGLE_ORGANIZATION | |
| ): |
Member
Author
There was a problem hiding this comment.
let me make this less confusing
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
still enforces org / project permissions