Skip to content

Conversation

@iamrajjoshi
Copy link
Collaborator

Found a typo where endpoint returns 404 in the data field instead of status. I caught this when the test was failing when I was updating the ProjectEndpoint convert_args. A 404 was correctly being returned (in the data field), but the test was checking the status_code, which was 200.

@iamrajjoshi iamrajjoshi requested a review from a team May 15, 2024 01:53
@iamrajjoshi iamrajjoshi self-assigned this May 15, 2024
@iamrajjoshi iamrajjoshi requested a review from a team as a code owner May 15, 2024 01:53
@iamrajjoshi iamrajjoshi changed the title fix(api): Update Endpoint so it Returns 404 as a Status fix(api): Update Endpoint so it Returns 404 as a status_code May 15, 2024
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 15, 2024
@iamrajjoshi iamrajjoshi merged commit 893a38b into master May 15, 2024
@iamrajjoshi iamrajjoshi deleted the raj/fix/endpoint/ppp branch May 15, 2024 13:33
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants