-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feat(custom-views): add custom views get endpoint #71942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
6e737b3 to
a4f03f3
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #71942 +/- ##
==========================================
+ Coverage 78.05% 78.07% +0.01%
==========================================
Files 6597 6599 +2
Lines 294016 294117 +101
Branches 50716 50728 +12
==========================================
+ Hits 229508 229620 +112
+ Misses 58246 58233 -13
- Partials 6262 6264 +2
|
| id: str | ||
| name: str | ||
| query: str | ||
| querySort: SORT_LITERALS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this not be typed as SortOptions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried for like an hour to get this to work before just giving up. For some reason, mypy refuses to enforce the type if I set it to SortOptions - I setquerySort of a view instance to "awioef" and mypy thought it was fine.
This endpoint creates the
GETorganizations/<org_id_or_slug>/group-search-views/Endpoint along with some tests. This endpoint will be responsible for fetching a user's custom views within an organization.mergedrun in production, and this branch will need to be rebased upon that happening