Skip to content

Conversation

@JoshFerge
Copy link
Member

  • previously we were getting a random hash associated with the group.
  • now, we simply use event.get_primary_hash()
  • removes passing down these hashes through the various functions as its not needed now
  • deletes a few tests where we were going through edge cases where we weren't finding a group_id associated with the hash .

@JoshFerge JoshFerge requested a review from a team June 4, 2024 17:09
@sentry
Copy link

sentry bot commented Jun 4, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: src/sentry/tasks/backfill_seer_grouping_records.py

Function Unhandled Issue
backfill_seer_grouping_records KeyError: 5172984251 sentry.tasks.backfill_seer_g...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 4, 2024
@JoshFerge JoshFerge merged commit 27a2f5e into master Jun 4, 2024
@JoshFerge JoshFerge deleted the jferg/remove-hashes-lookup branch June 4, 2024 17:56
@github-actions github-actions bot locked and limited conversation to collaborators Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants