ref(messaging): Removing Integration Namespace Imports #72033
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
ykamo001
approved these changes
Jun 4, 2024
Comment on lines
17
to
20
| def get_provider(instance: Integration | RpcIntegration) -> IntegrationProvider: | ||
| from sentry import integrations | ||
| from sentry.integrations.manager import default_manager as integrations | ||
|
|
||
| return integrations.get(instance.provider) |
Contributor
There was a problem hiding this comment.
Probably a sign that this method doesn't belong here, since the import should be happening the other way around. Or, if anything, move this to a util file under manager
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #72033 +/- ##
=======================================
Coverage 77.91% 77.91%
=======================================
Files 6573 6573
Lines 292707 292751 +44
Branches 50523 50527 +4
=======================================
+ Hits 228059 228100 +41
- Misses 58401 58406 +5
+ Partials 6247 6245 -2
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importing the entire
integrationmodule is bad practice and it turns out we only do it to access theIntegrationManager. I moved the instantiation of the manager back to the original file and import the manager directly.