fix(contexts): Fix casing for known context #72045
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
leeandher
commented
Jun 4, 2024
Comment on lines
340
to
+343
| case 'otel': | ||
| return t('OpenTelemetry'); | ||
| return 'OpenTelemetry'; | ||
| case 'unity': | ||
| return t('Unity'); | ||
| return 'Unity'; |
There was a problem hiding this comment.
These refer to specific companies and shouldn't be translated
malwilley
approved these changes
Jun 4, 2024
Bundle ReportChanges will increase total bundle size by 767 bytes ⬆️
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We wanted to preserve casing for unknown context from the sdk in #72013, but there are a few non-context context items that weren't accounted for.
Before
After
