Skip to content

tests(insights): add cache landing tests #72130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 5, 2024
Merged

tests(insights): add cache landing tests #72130

merged 2 commits into from
Jun 5, 2024

Conversation

@DominikB2014
Copy link
Contributor

@DominikB2014 DominikB2014 commented Jun 5, 2024 •
edited
Loading

  1. Add landing page tests for cache (TODO: SDK update banner tests)
  2. Perform some refactors mentioned in feat(insights): show update SDK banner cache module #72015

@DominikB2014 DominikB2014 requested review from a team and 0Calories June 5, 2024 16:36
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label Jun 5, 2024
@DominikB2014 DominikB2014 marked this pull request as draft June 5, 2024 16:37
@DominikB2014
Copy link
Contributor Author

DominikB2014 commented Jun 5, 2024

Sorry if you got pinged, going to add a check for the right request data being sent.

@DominikB2014 DominikB2014 marked this pull request as ready for review June 5, 2024 16:47
0Calories
0Calories approved these changes Jun 5, 2024
View reviewed changes
Copy link
Contributor

@0Calories 0Calories left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sick 👌

@DominikB2014 DominikB2014 merged commit 3132d36 into master Jun 5, 2024
@DominikB2014 DominikB2014 deleted the DominikB2014/cache-module-tests branch June 5, 2024 18:12
@sentry
Copy link

sentry bot commented Jun 6, 2024 •
edited
Loading

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: useNavigate() may be used only in the context of a component. useNavigate(useNavigate.tsx) View Issue
  • ‼️ Error: useNavigate() may be used only in the context of a component. useNavigate(useNavigate.tsx) View Issue
  • ‼️ Error: useNavigate() may be used only in the context of a component. useNavigate(useNavigate.tsx) View Issue
  • ‼️ TestingLibraryElementError: Unable to find an element with the text: Start collecting Insights about your Caches!. This could... Object.?(cacheLandingPage.spec.tsx) View Issue

Did you find this useful? React with a 👍 or 👎

@github-actions github-actions bot locked and limited conversation to collaborators Jul 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@0Calories 0Calories 0Calories approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Scope: Frontend Automatically applied to PRs that change frontend components

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DominikB2014 @0Calories