Skip to content

Conversation

@asottile-sentry
Copy link
Contributor

No description provided.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jun 14, 2024
@sentry
Copy link

sentry bot commented Jun 14, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: src/sentry/ingest/consumer/processors.py

Function Unhandled Issue
process_event Retriable: [Errno 111] Connection refused ingest_...
Event Count: 4

Did you find this useful? React with a 👍 or 👎

@codecov
Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.04%. Comparing base (701ae87) to head (817960e).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #72774      +/-   ##
==========================================
+ Coverage   73.27%   78.04%   +4.76%     
==========================================
  Files        6603     6604       +1     
  Lines      294288   294381      +93     
  Branches    50728    50750      +22     
==========================================
+ Hits       215652   229746   +14094     
+ Misses      72050    58300   -13750     
+ Partials     6586     6335     -251     
Files Coverage Δ
src/sentry/ingest/consumer/processors.py 85.13% <ø> (+10.13%) ⬆️

... and 843 files with indirect coverage changes

@asottile-sentry asottile-sentry force-pushed the asottile-kill-canonical-dict branch from 31400dc to 83e7fb8 Compare June 17, 2024 18:42
@asottile-sentry asottile-sentry marked this pull request as ready for review June 17, 2024 18:57
@asottile-sentry asottile-sentry requested review from a team as code owners June 17, 2024 18:57
Copy link
Contributor

@iker-barriocanal iker-barriocanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup!

@asottile-sentry asottile-sentry merged commit bc2f6d9 into master Jun 18, 2024
@asottile-sentry asottile-sentry deleted the asottile-kill-canonical-dict branch June 18, 2024 13:51
@github-actions github-actions bot locked and limited conversation to collaborators Jul 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Scope: Backend Automatically applied to PRs that change backend components

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants