ref: fix typing for sentry.buffer.base #72809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
asottile-sentry
commented
Jun 14, 2024
| pass | ||
| else: | ||
| group.update(**update_kwargs) | ||
| group.update(using=None, **update_kwargs) |
Contributor
Author
There was a problem hiding this comment.
this one is a bit annoying, because using could be passed as a named or positional it could collide with arbitrary names in update_kwargs so the type checker rejects it. explicitly passing the default here appeases the checker though
Member
There was a problem hiding this comment.
what's the annoyance? seems fine to me as it's just overridden if present in update_kwargs
Contributor
Author
There was a problem hiding this comment.
in practice we don't have fields named using so it couldn't possibly collide
joshuarli
approved these changes
Jun 14, 2024
andreiborza
pushed a commit
that referenced
this pull request
Jun 17, 2024
<!-- Describe your PR here. -->
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.